From: Matt Domsch <Matt_Domsch@dell.com>
To: Greg KH <greg@kroah.com>
Cc: "K, Narendra" <Narendra_K@dell.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-hotplug@vger.kernel.org" <linux-hotplug@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Hargrave, Jordan" <Jordan_Hargrave@dell.com>,
"Rose, Charles" <Charles_Rose@dell.com>,
"Nijhawan, Vijay" <Vijay_Nijhawan@dell.com>
Subject: Re: [PATCH 1/2] Export firmware assigned labels of network devices to sysfs
Date: Fri, 28 May 2010 18:11:00 +0000 [thread overview]
Message-ID: <20100528181100.GA12806@auslistsprd01.us.dell.com> (raw)
In-Reply-To: <20100528154041.GA27186@kroah.com>
On Fri, May 28, 2010 at 08:40:41AM -0700, Greg KH wrote:
> On Fri, May 28, 2010 at 06:55:21AM -0500, K, Narendra wrote:
> > +static const char dell_dsm_uuid[] = {
>
> Um, a dell specific uuid in a generic file? What happens when we need
> to support another manufacturer?
>
> > + 0xD0, 0x37, 0xC9, 0xE5, 0x53, 0x35, 0x7A, 0x4D,
> > + 0x91, 0x17, 0xEA, 0x4D, 0x19, 0xC3, 0x43, 0x4D
> > +};
This simply needs to be renamed. It's defined in the ECN, so will be
part of the spec, and is not vendor-unique, but defined once for all
implementations. It separates this _DSM function from others.
Thanks for the quick feedback.
Thanks,
Matt
--
Matt Domsch
Technology Strategist
Dell | Office of the CTO
next prev parent reply other threads:[~2010-05-28 18:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 11:55 [PATCH 1/2] Export firmware assigned labels of network devices to K, Narendra
2010-05-28 13:16 ` [PATCH 1/2] Export firmware assigned labels of network devices Domsch, Matt
2010-05-28 15:40 ` Greg KH
2010-05-28 18:11 ` Matt Domsch [this message]
2010-05-28 22:27 ` Greg KH
2010-05-29 4:51 ` Domsch, Matt
2010-06-09 4:17 ` [PATCH 1/2] Export firmware assigned labels of network devices to sysfs Matt Domsch
2010-06-09 15:02 ` [PATCH 1/2] Export firmware assigned labels of network devices Greg KH
2010-05-31 7:55 ` [PATCH 1/2] Export firmware assigned labels of network devices to sysfs Narendra_K
2010-05-31 14:07 ` [PATCH 1/2] Export firmware assigned labels of network devices Michael Ellerman
2010-05-31 18:54 ` [PATCH 1/2] Export firmware assigned labels of network devices to sysfs Narendra_K
2010-06-02 23:54 ` [PATCH 1/2] Export firmware assigned labels of network devices Michael Ellerman
[not found] <EDA0A4495861324DA2618B4C45DCB3EE612AB6@blrx3m08.blr.amer.dell.com>
2010-06-29 16:28 ` [PATCH 1/2] Export firmware assigned labels of network devices to sysfs Narendra K
[not found] <EDA0A4495861324DA2618B4C45DCB3EE612B1B@blrx3m08.blr.amer.dell.com>
2010-07-06 18:52 ` Narendra K
[not found] <EDA0A4495861324DA2618B4C45DCB3EE612B27@blrx3m08.blr.amer.dell.com>
2010-07-07 17:48 ` Narendra K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528181100.GA12806@auslistsprd01.us.dell.com \
--to=matt_domsch@dell.com \
--cc=Charles_Rose@dell.com \
--cc=Jordan_Hargrave@dell.com \
--cc=Narendra_K@dell.com \
--cc=Vijay_Nijhawan@dell.com \
--cc=greg@kroah.com \
--cc=linux-hotplug@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).