From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Domsch Date: Fri, 28 May 2010 18:11:00 +0000 Subject: Re: [PATCH 1/2] Export firmware assigned labels of network devices to sysfs Message-Id: <20100528181100.GA12806@auslistsprd01.us.dell.com> List-Id: References: <20100528115520.GA24114@littleblue.us.dell.com> <20100528154041.GA27186@kroah.com> In-Reply-To: <20100528154041.GA27186@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg KH Cc: "K, Narendra" , "netdev@vger.kernel.org" , "linux-hotplug@vger.kernel.org" , "linux-pci@vger.kernel.org" , "Hargrave, Jordan" , "Rose, Charles" , "Nijhawan, Vijay" On Fri, May 28, 2010 at 08:40:41AM -0700, Greg KH wrote: > On Fri, May 28, 2010 at 06:55:21AM -0500, K, Narendra wrote: > > +static const char dell_dsm_uuid[] = { > > Um, a dell specific uuid in a generic file? What happens when we need > to support another manufacturer? > > > + 0xD0, 0x37, 0xC9, 0xE5, 0x53, 0x35, 0x7A, 0x4D, > > + 0x91, 0x17, 0xEA, 0x4D, 0x19, 0xC3, 0x43, 0x4D > > +}; This simply needs to be renamed. It's defined in the ECN, so will be part of the spec, and is not vendor-unique, but defined once for all implementations. It separates this _DSM function from others. Thanks for the quick feedback. Thanks, Matt -- Matt Domsch Technology Strategist Dell | Office of the CTO