Re: New rule for xD FTL driver

[Greg KH <greg@kroah.com>]

On Tue, Jun 15, 2010 at 02:55:49AM +0300, Maxim Levitsky wrote:
> On Mon, 2010-06-14 at 09:46 -0700, Greg KH wrote: 
> > On Sat, Jun 12, 2010 at 03:54:04PM +0300, Maxim Levitsky wrote:
> > > Hi,
> > > 
> > > I have written a driver for xD card reader and xD/SmartMedia FTL that is
> > > usually mandatory to use with xD cards.
> > > 
> > > I think this can be added to 80-drivers.rule
> > > SUBSYSTEM="mtd", RUN+="/sbin/modprobe sm_ftl"
> > 
> > Why does this module not have the proper MODULE_DEVICE() or aliases in
> > it so that you don't have to manually load the module?  This should not
> > need to be a udev rule.
> 
> Well mtd system is not using bus model.

Why not?  It should be fixed to do so.

> However a card needs to be probed (theoteticly) by several high-level
> FTL drivers to make one of them to bind to it. (In fact several can bind
> at same now, which is both bad and good feature).

Then why would you write a rule to automatically load the module on the
system no matter what?

> I understand that module can have aliases so it can bind to a bus.

module aliases are used by modprobe to know what module to load when a
device is found on a bus.

> Of course I can do a 'request_module', but I think it isn't nice thing
> to do.

Agreed.  But as it looks like you always want this module loaded, why
not just make it part of your mtd core?

thanks,

greg k-h