udev-161-1 breaks DVD-ROM

udev-161-1 breaks DVD-ROM

[Борис Васильев]

Hi, sorry for the bad English. I confirm the bug described in:
http://bugs.archlinux.org/task/20550?string=udev&project=1&type%5B0%5D=&sev%5B0%5D=&pri%5B0%5D=&due%5B0%5D=&reported%5B0%5D=&cat%5B0%5D=&status%5B0%5D=open&percent%5B0%5D=&opened=&dev=&closed=&duedatefrom=&duedateto=&changedfrom=&changedto=&openedfrom=&openedto=&closedfrom=&closedto
"Details
Description:
udev version udev-161-1 breaks DVD-ROM functionality on my computer.
After upgrade, putting in a DVD with data shows up as a blank DVD in GNOME.

reinstalling Udev 1.6.0-1 fixes everything

Additional info:
udev-161-1

Steps to reproduce:
put in a DVD with videos, pictures etc.. and it will show up as a blank  
cd/DVD"

My system:
Linux arch 2.6.35-ARCH #1 SMP PREEMPT Sat Aug 21 07:23:08 UTC 2010 i686  
Intel(R) Core(TM)2 Duo CPU E8200 @ 2.66GHz GenuineIntel GNU/Linux, GNOME  
2.30, CD-ROM: PIONEER DVD-RW DVR-212 1.24 PQ


Yours respectfully, Boris Vasilev/bobart@mail.ru

Re: udev-161-1 breaks DVD-ROM

[Martin Pitt]

Hello Борис,

Борис Васильев [2010-08-28 14:23 +0400]:
> udev version udev-161-1 breaks DVD-ROM functionality on my computer.
> After upgrade, putting in a DVD with data shows up as a blank DVD in GNOME.

I can't reproduce that here, so I need further debugging info. Can you
please give me the output of

  /lib/udev/cdrom_id --debug /dev/sr0

with the DVD-ROM in the drive for both version 160 and version 161?

Thanks,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Re: udev-161-1 breaks DVD-ROM

[Martin Pitt]

Martin Pitt [2010-08-30 10:14 +0200]:
> I can't reproduce that here, so I need further debugging info. Can you
> please give me the output of
> 
>   /lib/udev/cdrom_id --debug /dev/sr0
> 
> with the DVD-ROM in the drive for both version 160 and version 161?

Nevermind, those are already on the downstream bug. Will look there.

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Re: udev-161-1 breaks DVD-ROM

[Martin Pitt]

[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]

Hello again,

Борис Васильев [2010-08-28 14:23 +0400]:
> udev version udev-161-1 breaks DVD-ROM functionality on my computer.
> After upgrade, putting in a DVD with data shows up as a blank DVD in GNOME.

So, I looked at the two logs attached on the arch bug report.
Unfortunately the 161-1 log file was done without a medium in the
drive (or you did it too early and the drive didn't finish reading the
disk yet). Can you please re-do the 161-1 log?

But while I looked through the code, I noticed a flaw in the "DVD-RW
ro/seq" patch [1]: It inserts the ro/seq differentiation into
feature_profiles(), but this should just detect the drive
capabilities, not the medium state.  I fixed that in [2], but I
suppose this is not the complete fix for that bug yet, since it didn't
break DVD-ROM operations at all, it just falsely claimed that they
were rewritable.

Thanks,

Martin

[1] http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=cf2205a1986222fdc0238190f5742f54d943cd23
[2] http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=2458db3edd8d66827b34978ff471dff8f879e9ab 
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: udev-161-1 breaks DVD-ROM

[Martin Pitt]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

Hello again,

I just committed another fix for sloppy drive firmware, which would
previously lead to considering nonempty DVDs as blank:

http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=5e267ea5a36de0b2a9a8965ca93dd45bbd6b1a8b

There is quite a high chance that this will fix your problem. Can you
try this (or ask Arch Linux in the downstream report to provide a
matching package for testing)?

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]