linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <Narendra_K@Dell.com>
To: kay.sievers@vrfy.org
Cc: greg@kroah.com, Matt_Domsch@Dell.com, netdev@vger.kernel.org,
	linux-hotplug@vger.kernel.org, linux-pci@vger.kernel.org,
	Jordan_Hargrave@Dell.com, Vijay_Nijhawan@Dell.com,
	Charles_Rose@Dell.com
Subject: Re: [PATCH V2] Use firmware provided index to register a network
Date: Thu, 07 Oct 2010 18:44:57 +0000	[thread overview]
Message-ID: <20101007184440.GA2999@libnet-test.oslab.blr.amer.dell.com> (raw)
In-Reply-To: <AANLkTinP5WPDPvk+kq8vsyP=xC9qcoe+c=1EBp0XJNPk@mail.gmail.com>

On Thu, Oct 07, 2010 at 10:35:14PM +0530, Kay Sievers wrote:
>    On Thu, Oct 7, 2010 at 18:48, Greg KH <greg@kroah.com> wrote:
>    > On Thu, Oct 07, 2010 at 11:31:13AM -0500, Matt Domsch wrote:
>    >> 1) SMBIOS type 41 method.  Windows does not use this today, and I
>    >>    can't speak to their future plans.  Narendra's kernel patch does,
>    >>    as has biosdevname, the udev helper we first wrote for this
>    >>    purpose, for several years.
>    >
>    > Then stick with that udev helper please :)
> 
>    What about just exporting this information in sysfs, and not touch the
>    naming?
> 
>    Anyway, I'm pretty sure all of this naming of onboard devices should
>    happen only at install time, or from a system management tool and not
>    at hotplug time.
> 
>    We should not get confused by the way the (very simple)
>    automatic-rule-creater for persistent netdev naming in udev works.
>    This is really just a tool for the common case, and works fine for the
>    majority of people.

Right. It works as the automatic rule creator saves the snapshot of the
registered network interfaces at run time. 

> 
>    I'm not sure, if we should put all these special use cases in the
>    hotplug path. I mean it's not that people add and remove 4 port
>    network cards with special BIOS all the time, and expect proper naming
>    on the first bootup, right? The installer, or the system management
>    tool could just create/edit udev rules to provide proper device naming
>    on whatever property is available at a specific hardware, be it the
>    MAC address or some other persistent match?
> 

The proposal made is not expecting deterministic naming when an add-in
card with 'N' ports is plugged in/out. It is specific to onboard devices
only. Expectation is onboard devices have deterministic naming at first
bootup. And no special BIOS required as SMBIOS tables are in use for
sometime now.

I did explore using rules based on the exported attribute ATTRS{index}
on a system with 4 Onboard devices and two add-in devices.(where add-in
device becomes eth0 and eth1)

# PCI device 0x14e4:0x164c (bnx2) (custom name provided by external
# tool) SUBSYSTEM="net", ACTION="add", DRIVERS="?*",
# ATTRS{index}="1", ATTR{type}="1", KERNEL="eth*", NAME="eth0"

(and similary for eth1..eth3)

And for add-in devices.

# PCI device 0x8086:0x10c9 (igb) (custom name provided by external tool)
# SUBSYSTEM="net", ACTION="add", DRIVERS="?*",
# ATTR{address}="00:1b:21:54:33:3c", ATTR{type}="1", KERNEL="eth*",
# NAME="eth4" (and similar for eth5 as they do not have an index)

This works as i edited the file manually.

If this has to be done on a large number of systems where an image
based deployment is preferred, getting onboard device names as expected
is an issue and is important.

-- 
With regards,
Narendra K

  parent reply	other threads:[~2010-10-07 18:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-07 14:23 [PATCH V2] Use firmware provided index to register a network Narendra_K
2010-10-07 15:11 ` Greg KH
2010-10-07 16:31   ` [PATCH V2] Use firmware provided index to register a network interface Matt Domsch
2010-10-07 16:48     ` [PATCH V2] Use firmware provided index to register a network Greg KH
2010-10-07 17:05       ` [PATCH V2] Use firmware provided index to register a network interface Kay Sievers
2010-10-07 17:15         ` [PATCH V2] Use firmware provided index to register a network Greg KH
2010-10-07 17:56           ` Narendra_K
2010-10-07 18:44         ` Narendra_K [this message]
2010-10-07 20:42         ` Matt Domsch
2010-10-07 16:49     ` David Lamparter
2010-10-07 17:13       ` [PATCH V2] Use firmware provided index to register a network interface Kay Sievers
2010-10-07 16:14 ` [PATCH V2] Use firmware provided index to register a network Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101007184440.GA2999@libnet-test.oslab.blr.amer.dell.com \
    --to=narendra_k@dell.com \
    --cc=Charles_Rose@Dell.com \
    --cc=Jordan_Hargrave@Dell.com \
    --cc=Matt_Domsch@Dell.com \
    --cc=Vijay_Nijhawan@Dell.com \
    --cc=greg@kroah.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-hotplug@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).