[PATCH 1/1] Remap Acer WMI touchpad toggle key to F21 used by X

[PATCH 1/1] Remap Acer WMI touchpad toggle key to F21 used by X

[Lee, Chun-Yi]

Currently, Acer WMI driver generates KEY_F22 but this
will soon change to KEY_TOUCHPAD_TOOGLE.

X has defined F21 for the purpose of touchpad toggle and other
udev keymaps align with this meaning.  Patch aligns Acer WMI
hotkey drivers with F21.

Tested on Acer TravelMate 8572 notebook using acer-wmi driver.

Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
Cc: Corentin Chary <corentincj@iksaif.net>
Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
---
 extras/keymap/95-keymap.rules |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/extras/keymap/95-keymap.rules b/extras/keymap/95-keymap.rules
index dd511d5..7f849d3 100644
--- a/extras/keymap/95-keymap.rules
+++ b/extras/keymap/95-keymap.rules
@@ -46,6 +46,7 @@ ENV{DMI_VENDOR}="ASUS*", KERNELS="input*", ATTRS{name}="Asus Extra Buttons",
 ENV{DMI_VENDOR}="Sony*", KERNELS="input*", ATTRS{name}="Sony Vaio Keys", RUN+="keymap $name module-sony"
 ENV{DMI_VENDOR}="ASUS*", KERNELS="input*", ATTRS{name}="Eee PC WMI hotkeys", RUN+="keymap $name 0x6B f21"
 ENV{DMI_VENDOR}="ASUS*", KERNELS="input*", ATTRS{name}="Eee PC Hotkey Driver", RUN+="keymap $name 0x37 f21"
+ENV{DMI_VENDOR}="Acer*", KERNELS="input*", ATTRS{name}="Acer WMI hotkeys", RUN+="keymap $name 0x82 f21"
 
 # Older Vaios have some different keys
 ENV{DMI_VENDOR}="Sony*", ATTR{[dmi/id]product_name}="*PCG-C1*|*PCG-K25*|*PCG-F1*|*PCG-F2*|*PCG-F3*|*PCG-F4*|*PCG-F5*|*PCG-F6*|*PCG-FX*|*PCG-FRV*|*PCG-GR*|*PCG-TR*|*PCG-NV*|*PCG-Z*|*VGN-S360*", ATTRS{name}="Sony Vaio Keys", RUN+="keymap $name module-sony-old"
-- 
1.6.0.2

Re: [PATCH 1/1] Remap Acer WMI touchpad toggle key to F21 used by X

[Martin Pitt]

Hello Lee,

Lee, Chun-Yi [2011-03-01 19:16 +0800]:
> Currently, Acer WMI driver generates KEY_F22 but this
> will soon change to KEY_TOUCHPAD_TOOGLE.
> 
> X has defined F21 for the purpose of touchpad toggle and other
> udev keymaps align with this meaning.  Patch aligns Acer WMI
> hotkey drivers with F21.

Right, that's what we've agreed on between X.org and udev.

Applied, thanks!

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Re: [PATCH 1/1] Remap Acer WMI touchpad toggle key to F21 used

[Joey Lee]

Hi Martin, 

於 二，2011-03-01 於 12:54 +0100，Martin Pitt 提到：
> Hello Lee,
> 
> Lee, Chun-Yi [2011-03-01 19:16 +0800]:
> > Currently, Acer WMI driver generates KEY_F22 but this
> > will soon change to KEY_TOUCHPAD_TOOGLE.
> > 
> > X has defined F21 for the purpose of touchpad toggle and other
> > udev keymaps align with this meaning.  Patch aligns Acer WMI
> > hotkey drivers with F21.
> 
> Right, that's what we've agreed on between X.org and udev.
> 
> Applied, thanks!
> 
> Martin

Thank's and I will send patch to modify the touchpad toggle key in
acer-wmi driver.


Thank's
Joey Lee