From mboxrd@z Thu Jan  1 00:00:00 1970
From: Martin Pitt <martin.pitt@ubuntu.com>
Date: Thu, 10 Mar 2011 07:59:51 +0000
Subject: Re: [PATCH] Remap MSI Laptop touchpad on/off key to F22 and F23
Message-Id: <20110310075951.GB2513@piware.de>
MIME-Version: 1
Content-Type: multipart/mixed; boundary="G4iJoqBmSsgzjUCe"
List-Id: <linux-hotplug.vger.kernel.org>
References: <1299723432-15709-1-git-send-email-jlee@novell.com>
In-Reply-To: <1299723432-15709-1-git-send-email-jlee@novell.com>
To: linux-hotplug@vger.kernel.org


--G4iJoqBmSsgzjUCe
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Lee,

Lee, Chun-Yi [2011-03-10 10:17 +0800]:
> MSI Laptop driver will query the real touchpad state then emit
> KEY_TOUCHPAD_ON/OFF key.
>=20
> Currently, X has defined F22 for touchpad on and F23 for touchpad
> off. This patch aligns MSI Laptop driver's key with F22 and F23.

Thanks! I pushed this part to trunk.

> This patch also merge ID_INPUT_KEY=3D1 key to msi-laptop input device
> for workaround the input_id doesn't support keycode large then 256.

I skipped this part, though, as I'd much rather fix the actual bug in
id_input. I don't see anything off-hand there which would limit the
key bitmask scanning (the capabilities/key attribute) to 255. It
reserves a bitmask array of KEY_MAX bits, which
/usr/include/linux/input.h defines as 0x2ff, so the keys you define
(0x213 and 0x214) should be well within that range.

Can you please give me the capabilities/ev and capabilities/key
contents of that input device, and also the "udevadm info --export-db"
parts of that keyboard module (both /event and /input), or just attach
the full output when in doubt? With that information I should be able
to reproduce the problem locally.

Thank you,

Martin
--=20
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

--G4iJoqBmSsgzjUCe
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJNeIT1AAoJEPmIJawmtHuf3z0P/1wA4AeIdS7vOR7MdasqEyXA
oVMEcNQQv00TeNmlhgBcPqfpoUI3QvNqFjbHvOljMXNiRAEvBqMNx/tmt7yX6f6d
dPq60D+GikLxPs/mxECODo15KpDrwk30wk3U+lq4BbFLG25woRWgya1OyZ5EHiCp
MNqK1dPBdZ14bP+mQTxMr1XG6MIOYe0NfDp2Jeygp5J874BLTHRB4aRcA3FO0Qsh
IWZJaKMMr1CrSRJw8nWSeTg4SmUNIDfxpANuHgnCdYnhPkQw99Qyzjw73WX398VA
RNtAcIlnYSa/qaiBZKb1WZVUTKIv4MPmC1wh1MfPF1hfAOaV9mJ1GkUtk7t7JmOo
LOggU25VQpnNi4/d/op1n5V008+ARdL5NMY8dUycSF8GWjt4V6SWIo/CvQfS5Vkc
o96gDfFZPy2xW4nCE4B5+2OZpgVZKc54GUOslSiRxWazt1NHw2i8gWj2bY5YGq9I
KIlTmSp8mDn/0M9TmKQIROx4LwiCReJHuxTVAsBX1k/C1fMYmFVuQhVM0cfYmphh
Fw9U9lJ7H33N2cljsL5BQC6ow/OxvPd2Tk3DQ6M8YF6cBxc0HUHVKkR2ShlFMBmD
oz0K6MjI5iQkcZaQOVq7PAdxte0MigODNzJA6chU86lMjfOY741yPQLgCVi49fwL
GtwpzWz9B7AnLjGbcXZG
=Gbf2
-----END PGP SIGNATURE-----

--G4iJoqBmSsgzjUCe--