From: Martin Pitt <martin.pitt@ubuntu.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: Fwd: [PATCH] Remap MSI Laptop touchpad on/off key to F22 and F23
Date: Fri, 18 Mar 2011 13:55:41 +0000 [thread overview]
Message-ID: <20110318135541.GB4231@piware.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 1411 bytes --]
Hello Joey,
Joey Lee [2011-03-16 1:06 -0600]:
> P: /devices/virtual/input/input7
> E: UDEV_LOG=3
> E: DEVPATH=/devices/virtual/input/input7
> E: PRODUCT=19/0/0/0
> E: NAME="MSI Laptop hotkeys"
> E: PHYS="msi-laptop/input0"
> E: EV==3
> E: KEY==180000 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
> E: MODALIAS=input:b0019v0000p0000e0000-e0,1,k213,214,ramlsfw
> E: SUBSYSTEM=input
Ah, thanks for this data. This indeed helped to demonstrate the
problem. First I added some debugging output to input_id [1].
While debugging I got an overflow, because your data is apparently
from a 32 bit machine/kernel, while I'm running 64 bit. I fixed that
as well while I was at it [2]. After fudging the data to be in the
proper 64 bit format, I was able to see what the KEY_MAX problem was.
Unfortunately the KEY_* and BTN_* blocks are alternating in
linux/input.h, so the fix looks a bit unelegant, but it works now [3].
Thanks!
Martin
[1] http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=941c40bdc47d1fdee651558dd0e162cd8d674fab
[2] http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=88149f668ea7ac23c61f6d1982db4f4517da763c
[3] http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=792479aca54d266430c900f90557ea8d0da2c125
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2011-03-18 13:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 13:55 Martin Pitt [this message]
2011-03-22 4:22 ` Fwd: [PATCH] Remap MSI Laptop touchpad on/off key to F22 Joey Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110318135541.GB4231@piware.de \
--to=martin.pitt@ubuntu.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).