From mboxrd@z Thu Jan  1 00:00:00 1970
From: Martin Pitt <martin.pitt@ubuntu.com>
Date: Fri, 18 Mar 2011 13:55:41 +0000
Subject: Re: Fwd: [PATCH] Remap MSI Laptop touchpad on/off key to F22 and F23
Message-Id: <20110318135541.GB4231@piware.de>
MIME-Version: 1
Content-Type: multipart/mixed; boundary="lrZ03NoBR/3+SXJZ"
List-Id: <linux-hotplug.vger.kernel.org>
To: linux-hotplug@vger.kernel.org


--lrZ03NoBR/3+SXJZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Joey,

Joey Lee [2011-03-16  1:06 -0600]:
> P: /devices/virtual/input/input7
> E: UDEV_LOG=3D3
> E: DEVPATH=3D/devices/virtual/input/input7
> E: PRODUCT=3D19/0/0/0
> E: NAME=3D"MSI Laptop hotkeys"
> E: PHYS=3D"msi-laptop/input0"
> E: EV=3D=3D3
> E: KEY=3D=3D180000 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
> E: MODALIAS=3Dinput:b0019v0000p0000e0000-e0,1,k213,214,ramlsfw
> E: SUBSYSTEM=3Dinput

Ah, thanks for this data. This indeed helped to demonstrate the
problem. First I added some debugging output to input_id [1].

While debugging I got an overflow, because your data is apparently
=66rom a 32 bit machine/kernel, while I'm running 64 bit. I fixed that
as well while I was at it [2]. After fudging the data to be in the
proper 64 bit format, I was able to see what the KEY_MAX problem was.
Unfortunately the KEY_* and BTN_* blocks are alternating in
linux/input.h, so the fix looks a bit unelegant, but it works now [3].

Thanks!

Martin

[1] http://git.kernel.org/?p=3Dlinux/hotplug/udev.git;a=3Dcommitdiff;h=3D94=
1c40bdc47d1fdee651558dd0e162cd8d674fab
[2] http://git.kernel.org/?p=3Dlinux/hotplug/udev.git;a=3Dcommitdiff;h=3D88=
149f668ea7ac23c61f6d1982db4f4517da763c
[3] http://git.kernel.org/?p=3Dlinux/hotplug/udev.git;a=3Dcommitdiff;h=3D79=
2479aca54d266430c900f90557ea8d0da2c125
--=20
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

--lrZ03NoBR/3+SXJZ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJNg2RcAAoJEPmIJawmtHufFo0P/iSTAbHP75u+Yw4pZzdA7qtg
taU1fJO+RJOeatsLnBxi5HjktLtPsMiQaJ91YV70zk/agQShbJQD4XkZBxHfQ35L
R1X8jTeeoN4UKf9WJa6qlEumxyDPdGD0ye68fW9+cwfjHNst+Vx4inUaMgDGI2ky
VOufF+j0+iXwRQJkPctgo+IYRm7qidiVSdWXS5oD/sUS1lDOGIdA5S41bC7wAbeB
c2UOChOgeWlg35WdgST9LM+PdUfGdygM6rFwIaeZwu7Ta8/luFCnCZ4BOpSxPHPq
aUQGHO/EfLcF01575yMWgBmyln0t/jm1ecfdXrXrUodqLml0Yo7nabALvhs3+dIk
uGKwqaZ5UHADE9d71Qel3mob681GJiJ25Fz0jlsEBFkKXl+lYoqhEnSrET2p34SX
EOBIhylpxJvHzGzx5L0SfYuwWKMj7Y5vyPyYXYWkw15i6YG0KOfTcip+NHm2iKWs
p7pnoCvn93ddI4Fy1iHwe4QJhwxaBtd3wkxoEa2i+WvoLfdKhKlZrntOHOFCg0yH
mQ85QpWpjSWxfP2l4b30lglpwDj8I/YS+wDrMNGYEFBOvLhjYK7QYE41SDEHOqwY
0EnmxnrqIBJbyElF1wro+ejt+PXtOC855Xa6b/pPcbf3ghl/yovQ3WJ/dNa/oFrd
qr+JV+2B70bARcx3vAeK
=dYAN
-----END PGP SIGNATURE-----

--lrZ03NoBR/3+SXJZ--