From: Martin Pitt <martin.pitt@ubuntu.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] udevd.c: Add 'N:' to optstring in getopt_long
Date: Thu, 31 Mar 2011 14:30:06 +0000 [thread overview]
Message-ID: <20110331143006.GB4480@piware.de> (raw)
In-Reply-To: <4D947C4F.6060301@secunet.com>
Hello Thomas,
Thomas Egerer [2011-03-31 15:06 +0200]:
> - option = getopt_long(argc, argv, "c:deDthV", options, NULL);
> + option = getopt_long(argc, argv, "c:deDthN:V", options, NULL);
This is certainly an inconsistency, but I wonder if we shouldn't
instead just remove the other short options from the optstring?
Neither --help nor the manpage document the short versions, so they
could be considered a kind of implementation detail?
I. e. we should perhaps only support the documented long options.
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
next prev parent reply other threads:[~2011-03-31 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 13:06 [PATCH] udevd.c: Add 'N:' to optstring in getopt_long Thomas Egerer
2011-03-31 14:30 ` Martin Pitt [this message]
2011-03-31 15:21 ` Kay Sievers
2011-03-31 15:29 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331143006.GB4480@piware.de \
--to=martin.pitt@ubuntu.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).