From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Pitt Date: Thu, 31 Mar 2011 14:30:06 +0000 Subject: Re: [PATCH] udevd.c: Add 'N:' to optstring in getopt_long Message-Id: <20110331143006.GB4480@piware.de> List-Id: References: <4D947C4F.6060301@secunet.com> In-Reply-To: <4D947C4F.6060301@secunet.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Hello Thomas, Thomas Egerer [2011-03-31 15:06 +0200]: > - option = getopt_long(argc, argv, "c:deDthV", options, NULL); > + option = getopt_long(argc, argv, "c:deDthN:V", options, NULL); This is certainly an inconsistency, but I wonder if we shouldn't instead just remove the other short options from the optstring? Neither --help nor the manpage document the short versions, so they could be considered a kind of implementation detail? I. e. we should perhaps only support the documented long options. Martin -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)