From: "Rafał Mużyło" <galtgendo@gmail.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: In regard of commit "gudev: Use strtoul to parse unsigned 64-bit
Date: Mon, 31 Oct 2011 21:04:03 +0000 [thread overview]
Message-ID: <20111031210403.GB2447@blackspire> (raw)
In-Reply-To: <20111031201318.GA2447@blackspire>
On Mon, Oct 31, 2011 at 04:32:07PM -0400, David Zeuthen wrote:
> On Mon, Oct 31, 2011 at 4:13 PM, Rafał Mużyło <galtgendo@gmail.com> wrote:
> > Perhaps I'm simply misreading something, but won't going from strtoll to
> > strtoul break things for 32bit case ?
>
> What do you think it would break? Or are you perhaps suggesting we
> should be using strtoull() instead? Please be specific.
>
Well, given on what happens on strtoul overflow according to the
manpage...
But, as you're the main author of udisks, would you mind looking at the
bug I've mentioned ?
Perhaps it doesn't matter there, but it would be good to do something
about the warnings.
next prev parent reply other threads:[~2011-10-31 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 20:13 In regard of commit "gudev: Use strtoul to parse unsigned 64-bit Rafał Mużyło
2011-10-31 20:32 ` In regard of commit "gudev: Use strtoul to parse unsigned 64-bit integers" David Zeuthen
2011-10-31 20:44 ` David Zeuthen
2011-10-31 21:04 ` Rafał Mużyło [this message]
2011-10-31 21:18 ` David Zeuthen
2011-10-31 21:22 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111031210403.GB2447@blackspire \
--to=galtgendo@gmail.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).