From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?UmFmYcWCIE11xbx5xYJv?= Date: Mon, 31 Oct 2011 21:04:03 +0000 Subject: Re: In regard of commit "gudev: Use strtoul to parse unsigned 64-bit Message-Id: <20111031210403.GB2447@blackspire> List-Id: References: <20111031201318.GA2447@blackspire> In-Reply-To: <20111031201318.GA2447@blackspire> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: linux-hotplug@vger.kernel.org On Mon, Oct 31, 2011 at 04:32:07PM -0400, David Zeuthen wrote: > On Mon, Oct 31, 2011 at 4:13 PM, Rafał Mużyło wrote: > > Perhaps I'm simply misreading something, but won't going from strtoll to > > strtoul break things for 32bit case ? > > What do you think it would break? Or are you perhaps suggesting we > should be using strtoull() instead? Please be specific. > Well, given on what happens on strtoul overflow according to the manpage... But, as you're the main author of udisks, would you mind looking at the bug I've mentioned ? Perhaps it doesn't matter there, but it would be good to do something about the warnings.