linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Pitt <martin.pitt@ubuntu.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] extras/keymap/findkeyboards: beautify shell code and get
Date: Mon, 07 Nov 2011 16:54:42 +0000	[thread overview]
Message-ID: <20111107165442.GB2970@piware.de> (raw)
In-Reply-To: <1320662666-27558-1-git-send-email-harald@redhat.com>

Hello Harald,

harald@redhat.com [2011-11-07 14:54 +0100]:
> - save some extra forks and grep with shell code instead of calling
>   grep
> - use $() instead of backticks (improves readability and addes
>   nesting capabilities)

Thanks! Applied.

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

      parent reply	other threads:[~2011-11-07 16:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07 10:44 [PATCH] extras/keymap/findkeyboards: beautify shell code and get rid of grep harald
2011-11-07 13:54 ` harald
2011-11-07 13:56 ` [PATCH] extras/keymap/findkeyboards: beautify shell code and Harald Hoyer
2011-11-07 16:54 ` Martin Pitt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111107165442.GB2970@piware.de \
    --to=martin.pitt@ubuntu.com \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).