From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Pitt Date: Mon, 07 Nov 2011 16:54:42 +0000 Subject: Re: [PATCH] extras/keymap/findkeyboards: beautify shell code and get Message-Id: <20111107165442.GB2970@piware.de> List-Id: References: <1320662666-27558-1-git-send-email-harald@redhat.com> In-Reply-To: <1320662666-27558-1-git-send-email-harald@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Hello Harald, harald@redhat.com [2011-11-07 14:54 +0100]: > - save some extra forks and grep with shell code instead of calling > grep > - use $() instead of backticks (improves readability and addes > nesting capabilities) Thanks! Applied. Martin -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)