From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andrew Vagin <avagin@openvz.org>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
linux-hotplug@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uevent: send events in correct order according to seqnum (v3)
Date: Wed, 07 Mar 2012 15:45:17 +0000 [thread overview]
Message-ID: <20120307154517.GA16080@kroah.com> (raw)
In-Reply-To: <1331117396-11600-1-git-send-email-avagin@openvz.org>
On Wed, Mar 07, 2012 at 02:49:56PM +0400, Andrew Vagin wrote:
> The queue handling in the udev daemon assumes that the events are
> ordered.
>
> Before this patch uevent_seqnum is incremented under sequence_lock,
> than an event is send uner uevent_sock_mutex. I want to say that code
> contained a window between incrementing seqnum and sending an event.
Is this something that you have seen "in the wild"? If so, we should
backport it to older kernels as well, right?
thanks,
greg k-h
next prev parent reply other threads:[~2012-03-07 15:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 8:48 [PATCH] udev: fix problem due to unsorted events Andrey Vagin
2012-03-06 11:06 ` Kay Sievers
2012-03-06 12:43 ` Kay Sievers
2012-03-06 20:06 ` [PATCH] uevent: send events in correct order according to seqnum Andrew Vagin
2012-03-06 21:03 ` Kay Sievers
2012-03-06 21:14 ` avagin
2012-03-07 5:52 ` Greg Kroah-Hartman
2012-03-07 9:59 ` [PATCH] uevent: send events in correct order according to seqnum (v2) Andrew Vagin
2012-03-07 10:18 ` Kay Sievers
2012-03-07 10:49 ` [PATCH] uevent: send events in correct order according to seqnum (v3) Andrew Vagin
2012-03-07 11:03 ` Kay Sievers
2012-03-07 15:45 ` Greg Kroah-Hartman [this message]
2012-03-07 17:34 ` Andrew Wagin
2012-03-07 17:47 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307154517.GA16080@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=avagin@openvz.org \
--cc=kay.sievers@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).