linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ren Mingxin <renmx@cn.fujitsu.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Kay Sievers <kay.sievers@vrfy.org>,
	Tokunaga Kei <tokunaga.keiich@jp.fujitsu.com>,
	LKML <linux-kernel@vger.kernel.org>,
	UDEV <linux-hotplug@vger.kernel.org>
Subject: Re: [RFC PATCH] virtio_blk: Checking "private_data"  to avoid kernel panic when hotplugging
Date: Mon, 09 Apr 2012 07:53:18 +0000	[thread overview]
Message-ID: <20120409075318.GB27771@redhat.com> (raw)
In-Reply-To: <4F728831.2090406@cn.fujitsu.com>

On Wed, Mar 28, 2012 at 11:40:33AM +0800, Ren Mingxin wrote:
>  Hi,
> 
> On guest with upstream's kernel(3.3.0-rc7), I
> mounted virtblk as:
>   a) # mkfs /dev/vda
>   b) # mount /dev/vda /mnt
>   c) # cd /mnt
> 
> Then I did hotplug for virtblk via virsh on host as:
>   a) # sudo virsh detach-disk guest vda
>   b) # sudo virsh attach-disk guest /media/data/test.img vda
> 
> I encountered guest's kernel panic (*probability *
> *event*)whose backtrace liked this:

Any news here? Managed to trace?
Does this still happen with 3.4-rc2?
There's a chance you are hitting a race fixed by
4678d6f970c2f7c0cbfefc0cc666432d153b321b.

If it's still not fixed it might make sense to enable slab debugging -
we might have a use after free here.

-- 
MST

  parent reply	other threads:[~2012-04-09  7:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-28  3:40 [RFC PATCH] virtio_blk: Checking "private_data" to avoid kernel panic when hotplugging Ren Mingxin
2012-03-28 11:11 ` Michael S. Tsirkin
2012-03-29  4:11   ` Ren Mingxin
2012-03-29 10:30     ` Michael S. Tsirkin
2012-04-09  7:53 ` Michael S. Tsirkin [this message]
2012-04-11  3:17   ` Ren Mingxin
2012-04-11  8:36     ` Michael S. Tsirkin
2012-04-11  9:09       ` Ren Mingxin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120409075318.GB27771@redhat.com \
    --to=mst@redhat.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-hotplug@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=renmx@cn.fujitsu.com \
    --cc=rusty@rustcorp.com.au \
    --cc=tokunaga.keiich@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).