From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Kay Sievers" <kay.sievers@vrfy.org>
Date: Mon, 01 Sep 2008 14:32:37 +0000
Subject: Re: [PATCH] Some function locals in udev_rules_parse.c were needlessly declared as static
Message-Id: <3ae72650809010732l5eef99d2mc1dde8feac1e7cdf@mail.gmail.com>
List-Id: <linux-hotplug.vger.kernel.org>
References: <48BAD549.6080304@tuffmail.co.uk>
In-Reply-To: <48BAD549.6080304@tuffmail.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-hotplug@vger.kernel.org

On Sun, Aug 31, 2008 at 19:30, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
> This does not affect current behaviour.  However, it is required to
> make the functions thread-safe.  (I'm playing with a threaded udevd).

> -       static struct udev_rule *rule;
> +       struct udev_rule *rule;

It's not needlessly static, we return _this_ value. The parsing stuff
is not thread safe at the moment, we would need a real fix, this would
break it.

Thanks,
Kay