* udevinfo output broken
@ 2004-01-27 20:06 Olaf Hering
2004-01-27 21:12 ` Kay Sievers
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Olaf Hering @ 2004-01-27 20:06 UTC (permalink / raw)
To: linux-hotplug
udevinfo writes to fd 0, all the output is lost somehow.
olaf@ibook:~> /sbin/udevinfo -r
/dev/
olaf@ibook:~> i="`/sbin/udevinfo -r`"
/dev/
olaf@ibook:~> echo $i
olaf@ibook:~> i="`/sbin/udevinfo -r 2>&1`"
/dev/
olaf@ibook:~> echo $i
olaf@ibook:~>
--
USB is for mice, FireWire is for men!
sUse lINUX ag, n√úRNBERG
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: udevinfo output broken
2004-01-27 20:06 udevinfo output broken Olaf Hering
@ 2004-01-27 21:12 ` Kay Sievers
2004-01-27 21:19 ` Olaf Hering
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Kay Sievers @ 2004-01-27 21:12 UTC (permalink / raw)
To: linux-hotplug
On Tue, Jan 27, 2004 at 09:06:51PM +0100, Olaf Hering wrote:
> udevinfo writes to fd 0, all the output is lost somehow.
>
> olaf@ibook:~> i="`/sbin/udevinfo -r 2>&1`"
> /dev/
Seems like a klibc feature :)
libc works as expected.
Greg, any idea?
kay@pim:~$ i=`/sbin/udevinfo -r`; echo -$i-
-/udev/-
Kay
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: udevinfo output broken
2004-01-27 20:06 udevinfo output broken Olaf Hering
2004-01-27 21:12 ` Kay Sievers
@ 2004-01-27 21:19 ` Olaf Hering
2004-01-27 21:54 ` Olaf Hering
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Olaf Hering @ 2004-01-27 21:19 UTC (permalink / raw)
To: linux-hotplug
On Tue, Jan 27, Kay Sievers wrote:
> On Tue, Jan 27, 2004 at 09:06:51PM +0100, Olaf Hering wrote:
> > udevinfo writes to fd 0, all the output is lost somehow.
> >
> > olaf@ibook:~> i="`/sbin/udevinfo -r 2>&1`"
> > /dev/
>
> Seems like a klibc feature :)
> libc works as expected.
_fwrite gets 0x1 as f, calls fileno() which decrements it and passes it
to write().
--
USB is for mice, FireWire is for men!
sUse lINUX ag, n√úRNBERG
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: udevinfo output broken
2004-01-27 20:06 udevinfo output broken Olaf Hering
2004-01-27 21:12 ` Kay Sievers
2004-01-27 21:19 ` Olaf Hering
@ 2004-01-27 21:54 ` Olaf Hering
2004-01-27 22:05 ` Greg KH
2004-01-28 0:39 ` [klibc] " H. Peter Anvin
4 siblings, 0 replies; 6+ messages in thread
From: Olaf Hering @ 2004-01-27 21:54 UTC (permalink / raw)
To: linux-hotplug
On Tue, Jan 27, Olaf Hering wrote:
> On Tue, Jan 27, Kay Sievers wrote:
>
> > On Tue, Jan 27, 2004 at 09:06:51PM +0100, Olaf Hering wrote:
> > > udevinfo writes to fd 0, all the output is lost somehow.
> > >
> > > olaf@ibook:~> i="`/sbin/udevinfo -r 2>&1`"
> > > /dev/
> >
> > Seems like a klibc feature :)
> > libc works as expected.
>
> _fwrite gets 0x1 as f, calls fileno() which decrements it and passes it
> to write().
No idea if this is correct:
--- klibc-0.98/klibc/include/stdio.h 2004-01-22 21:56:49.000000000 +0100
+++ klibc/klibc/include/stdio.h 2004-01-27 22:50:27.000000000 +0100
@@ -15,9 +15,9 @@
struct _IO_file;
typedef struct _IO_file FILE;
-#define stdin ((FILE *)0)
-#define stdout ((FILE *)1)
-#define stderr ((FILE *)2)
+#define stdin ((FILE *)1)
+#define stdout ((FILE *)2)
+#define stderr ((FILE *)3)
#ifndef EOF
# define EOF (-1)
--
USB is for mice, FireWire is for men!
sUse lINUX ag, n√úRNBERG
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: udevinfo output broken
2004-01-27 20:06 udevinfo output broken Olaf Hering
` (2 preceding siblings ...)
2004-01-27 21:54 ` Olaf Hering
@ 2004-01-27 22:05 ` Greg KH
2004-01-28 0:39 ` [klibc] " H. Peter Anvin
4 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2004-01-27 22:05 UTC (permalink / raw)
To: linux-hotplug
On Tue, Jan 27, 2004 at 10:54:31PM +0100, Olaf Hering wrote:
> On Tue, Jan 27, Olaf Hering wrote:
>
> > On Tue, Jan 27, Kay Sievers wrote:
> >
> > > On Tue, Jan 27, 2004 at 09:06:51PM +0100, Olaf Hering wrote:
> > > > udevinfo writes to fd 0, all the output is lost somehow.
> > > >
> > > > olaf@ibook:~> i="`/sbin/udevinfo -r 2>&1`"
> > > > /dev/
> > >
> > > Seems like a klibc feature :)
> > > libc works as expected.
> >
> > _fwrite gets 0x1 as f, calls fileno() which decrements it and passes it
> > to write().
>
> No idea if this is correct:
>
> --- klibc-0.98/klibc/include/stdio.h 2004-01-22 21:56:49.000000000 +0100
> +++ klibc/klibc/include/stdio.h 2004-01-27 22:50:27.000000000 +0100
> @@ -15,9 +15,9 @@
> struct _IO_file;
> typedef struct _IO_file FILE;
>
> -#define stdin ((FILE *)0)
> -#define stdout ((FILE *)1)
> -#define stderr ((FILE *)2)
> +#define stdin ((FILE *)1)
> +#define stdout ((FILE *)2)
> +#define stderr ((FILE *)3)
>
> #ifndef EOF
> # define EOF (-1)
>
I don't know about your change, but I traced the regression down to this
recent recent change in klibc:
diff -Nru a/klibc/klibc/include/stdio.h b/klibc/klibc/include/stdio.h
--- a/klibc/klibc/include/stdio.h Tue Jan 27 14:00:35 2004
+++ b/klibc/klibc/include/stdio.h Tue Jan 27 14:00:35 2004
@@ -31,15 +31,22 @@
#define SEEK_CUR 1
#define SEEK_END 2
+/*
+ * Convert between a FILE * and a file descriptor. We don't actually
+ * have any in-memory data, so we just abuse the pointer itself to
+ * hold the data. Note, however, that for file descriptors, -1 is
+ * error and 0 is a valid value; for FILE *, NULL (0) is error and
+ * non-NULL are valid.
+ */
static __inline__ int fileno(FILE *__f)
{
/* This should really be intptr_t, but size_t should be the same size */
- return (int)(size_t)__f;
+ return (int)(size_t)__f - 1;
}
static __inline__ FILE * __create_file(int __fd)
{
- return (FILE *)(size_t)__fd;
+ return (FILE *)(size_t)(__fd + 1);
}
__extern FILE *fopen(const char *, const char *);
Peter, any reason for doing this? It seems to change the way stdout
works.
thanks,
greg k-h
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [klibc] Re: udevinfo output broken
2004-01-27 20:06 udevinfo output broken Olaf Hering
` (3 preceding siblings ...)
2004-01-27 22:05 ` Greg KH
@ 2004-01-28 0:39 ` H. Peter Anvin
4 siblings, 0 replies; 6+ messages in thread
From: H. Peter Anvin @ 2004-01-28 0:39 UTC (permalink / raw)
To: linux-hotplug
Greg KH wrote:
>
> Peter, any reason for doing this? It seems to change the way stdout
> works.
>
Yes, it's because 0 is valid fd, but NULL is an error return for stdio.
I forgot to fix stdin/out/err; will check in patch momentarily.
-hpa
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-01-28 0:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-27 20:06 udevinfo output broken Olaf Hering
2004-01-27 21:12 ` Kay Sievers
2004-01-27 21:19 ` Olaf Hering
2004-01-27 21:54 ` Olaf Hering
2004-01-27 22:05 ` Greg KH
2004-01-28 0:39 ` [klibc] " H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).