[PATCH] allow non-block devices for udevinfo

[Hannes Reinecke <hare@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

Hi all,

with the attached patch to udevinfo it is possible to look also at 
devices in /class which do not provide the 'dev' attribute, e.g. net 
devices.
Agreed, it is of limited usefulness as it stands, but with it we can 
check devices for consistency with the 'standard' or 'acceptable' 
behaviour re. sysfs. And complain loudly to the driver maintainer if 
they don't (Hi Arnd !).

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux AG				S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

[-- Attachment #2: udevinfo-net.patch --]
[-- Type: text/plain, Size: 782 bytes --]

===== udevinfo.c 1.13 vs edited =====
--- 1.13/udevinfo.c	Mon Feb 23 20:07:25 2004
+++ edited/udevinfo.c	Wed Feb 25 14:44:02 2004
@@ -143,14 +143,12 @@
 
 	/* read the 'dev' file for major/minor*/
 	attr = sysfs_get_classdev_attr(class_dev, "dev");
-	if (attr == NULL) {
-		printf("couldn't get the \"dev\" file\n");
-		retval = -1;
-		goto exit;
+	if (attr) {
+	    printf("\ndevice '%s' has major:minor %s", class_dev->path, 
+		   attr->value);
+	    sysfs_close_attribute(attr);
 	}
-	printf("\ndevice '%s' has major:minor %s", class_dev->path, attr->value);
-	sysfs_close_attribute(attr);
-
+	
 	/* open sysfs class device directory and print all attributes */
 	printf("  looking at class device '%s':\n", class_dev->path);
 	if (print_all_attributes(class_dev->path) != 0) {