From: Daniel Drake <dan@reactivated.net>
To: linux-hotplug@vger.kernel.org
Subject: Excess spaces in sysfs files
Date: Wed, 25 Feb 2004 21:25:16 +0000 [thread overview]
Message-ID: <403D12BC.40209@reactivated.net> (raw)
Hi,
I have met a minor issue when writing udev rules.
Some text-like files in /sys have a load of spaces appended onto the text.
Example below, part of the udevinfo for my camera (notice the model field):
follow the class device's "device"
looking at the device chain at
'/sys/devices/pci0000:00/0000:00:02.1/usb3/3-3/3-3:1.0/host0/0:0:0:0':
BUS="scsi"
ID="0:0:0:0"
SYSFS{detach_state}="0"
SYSFS{max_sectors}="240"
SYSFS{device_blocked}="0"
SYSFS{queue_depth}="1"
SYSFS{type}="0"
SYSFS{scsi_level}="3"
SYSFS{vendor}=" "
SYSFS{model}="USB 2.0M DSC "
SYSFS{rev}="1.00"
SYSFS{online}="1"
Second example, an iPod:
http://marc.theaimsgroup.com/?l=gentoo-user&m\x107773927301652&w=2
Of course, udevinfo makes it nice and clear that the extra spaces are there.
But if you are simply cat'ing the files in /sys its not that obvious.
My questions:
1. Should these spaces be here? Are devices really identifying themselves with
spaces on the end? Or is this an issue with sysfs/similar.
2. Should udev trim whitespace from the end of SYSFS{..} values (files), so
that keys such as
SYSFS{model} = "iPod"
would match a file containing
"iPod "
If the above behaviour is implemented, I would suggest having a second key
type, SYSFS_RAW{..} where whitespace is not trimmed. I am prepared to write a
patch for this.
Daniel.
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id\x1356&alloc_id438&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next reply other threads:[~2004-02-25 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-25 21:25 Daniel Drake [this message]
2004-02-25 22:49 ` Excess spaces in sysfs files Kay Sievers
2004-02-28 0:22 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=403D12BC.40209@reactivated.net \
--to=dan@reactivated.net \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).