Re: udevinfo patch

[Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2004@gmx.net>]

Ananth N Mavinakayanahalli wrote:
> On Fri, Mar 26, 2004 at 11:24:39AM +0100, Kay Sievers wrote:
> 
>>On Fri, Mar 26, 2004 at 11:21:29AM +0500, Ananth N Mavinakayanahalli wrote:
>>
>>>On Fri, Mar 26, 2004 at 04:47:35AM +0100, Kay Sievers wrote:
>>>
>>>>On Fri, Mar 26, 2004 at 01:26:46AM +0100, Carl-Daniel Hailfinger wrote:
>>>>
>>>>>Greg KH wrote:
>>>>>
>>>>>>On Tue, Mar 23, 2004 at 01:51:01PM -0800, Daniel Stekloff wrote:
>>>>
>>>>No, it breaks the net device handling. I think we should change
>>>>libsysfs instead, not to return a class device for '/block', if
>>>>we want to fix it.
>>>
>>>/sys/block is considered a sysfs "class" and not a class_device. So, 
>>>going by udevinfo's help, -p expects path to a class_device and _not_ 
>>>a class itself and hence option /sys/block with -p is not a valid query. 
>>>
>>>Kay?
>>
>>Yes, it's invalid, but we shouldn't print major minor for a invalid
>>path. sysfs_open_class_device_path("/block") returns a device. If this is
>>the right behavior for libsysfs, I will change the get_device_type("/block")
>>not to return a 'b'-type.
> 
> 
> Libsysfs validates the path given to it for opening a class_device to be
> a valid directory; it does not however validate if the path is a valid
> class_device path. So, in the case of udevinfo, a 'b' type should not 
> be returned if the path is just /sys/block or /sys/block/

Regardless of that, libsysfs should not claim something has a major/minor
if it has not.


Regards,
Carl-Daniel



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel