From: Brian King <brking@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
linux-hotplug-devel@lists.sourceforge.net
Subject: Re: [PATCH] call_usermodehelper hang
Date: Fri, 16 Apr 2004 17:55:25 +0000 [thread overview]
Message-ID: <40801E0D.70902@us.ibm.com> (raw)
In-Reply-To: 20040412104638.7b1d0124.akpm@osdl.org
I applied and tested the new patches in the mm tree and it works fine
for me.
Thanks
-Brian
Andrew Morton wrote:
> Brian King <brking@us.ibm.com> wrote:
>
>>>>Ok, you've convinced me of the mess that would cause. So what should we
>>>
>> >> do to help fix this? Serialize call_usermodehelper()?
>> >
>> >
>> > May as well bring back call_usermodehelper_async() I guess.
>> >
>> >
>> > There are two patches here, and they are totally untested...
>>
>> I loaded the patches on my ppc64 box and they worked fine after I fixed a compile
>> bug. The attached patch fixes the compile bug and changes the call_usermodehelper
>> call in kset_hotplug to call_usermodehelper_async.
>
>
> yup, thanks. I've changed the patch in my tree so that we always perform
> the fully-async operation if call_usermodehelper() is passed "wait=0". It
> gets the new code some more testing and keeps the kernel API simpler.
>
>
--
Brian King
eServer Storage I/O
IBM Linux Technology Center
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2004-04-16 17:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4072F2B7.2070605@us.ibm.com>
[not found] ` <20040406172903.186dd5f1.akpm@osdl.org>
[not found] ` <20040407061146.GA10413@kroah.com>
[not found] ` <407487A6.8020904@us.ibm.com>
2004-04-08 22:47 ` [PATCH] call_usermodehelper hang Greg KH
2004-04-09 20:42 ` Brian King
2004-04-09 20:53 ` Greg KH
2004-04-09 21:05 ` Brian King
2004-04-09 21:15 ` Andrew Morton
2004-04-10 16:53 ` Greg KH
2004-04-10 20:11 ` Andrew Morton
2004-04-12 15:25 ` Brian King
2004-04-12 17:46 ` Andrew Morton
2004-04-16 17:55 ` Brian King [this message]
2004-04-12 18:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40801E0D.70902@us.ibm.com \
--to=brking@us.ibm.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-hotplug-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).