From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian King Date: Fri, 16 Apr 2004 17:55:25 +0000 Subject: Re: [PATCH] call_usermodehelper hang Message-Id: <40801E0D.70902@us.ibm.com> List-Id: References: <4072F2B7.2070605@us.ibm.com> <20040406172903.186dd5f1.akpm@osdl.org> <20040407061146.GA10413@kroah.com> <407487A6.8020904@us.ibm.com> <20040408224713.GD15125@kroah.com> <40770AD0.4000402@us.ibm.com> <20040409205344.GA5236@kroah.com> <20040409141511.4e372554.akpm@osdl.org> <20040410165322.GG1317@kroah.com> <20040410131137.0eff0ae2.akpm@osdl.org> <407AB4FD.4070905@us.ibm.com> <20040412104638.7b1d0124.akpm@osdl.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton Cc: greg@kroah.com, linux-kernel@vger.kernel.org, linux-hotplug-devel@lists.sourceforge.net I applied and tested the new patches in the mm tree and it works fine for me. Thanks -Brian Andrew Morton wrote: > Brian King wrote: > >>>>Ok, you've convinced me of the mess that would cause. So what should we >>> >> >> do to help fix this? Serialize call_usermodehelper()? >> > >> > >> > May as well bring back call_usermodehelper_async() I guess. >> > >> > >> > There are two patches here, and they are totally untested... >> >> I loaded the patches on my ppc64 box and they worked fine after I fixed a compile >> bug. The attached patch fixes the compile bug and changes the call_usermodehelper >> call in kset_hotplug to call_usermodehelper_async. > > > yup, thanks. I've changed the patch in my tree so that we always perform > the fully-async operation if call_usermodehelper() is passed "wait=0". It > gets the new code some more testing and keeps the kernel API simpler. > > -- Brian King eServer Storage I/O IBM Linux Technology Center ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id70&alloc_id638&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel