Re: udev - flag for preserving the ownership

[Harald Hoyer <harald@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 575 bytes --]

Harald Hoyer wrote:
> How about a config flag, which means that udev preserves the ownership 
> of an already existing device node (with the correct major, minor numbers)?
> 
> Btw, we only check if the file we want to create is block or char, not 
> e.g. that we want block and it is char.
> 
> if (((stats.st_mode & S_IFMT) == S_IFBLK || (stats.st_mode & S_IFMT) == 
> S_IFCHR) && (stats.st_rdev == makedev(major, minor)))
> 
> should look like:
> 
> if (((stats.st_mode & S_IFMT) == mode) && (stats.st_rdev == 
> makedev(major, minor)))

how about this (see attachement)?

[-- Attachment #1.2: udev-025-keepowner.patch --]
[-- Type: text/x-patch, Size: 563 bytes --]

--- udev-025/udev-add.c.keep	2004-04-21 23:39:10.000000000 +0200
+++ udev-025/udev-add.c	2004-06-02 12:08:16.728855024 +0200
@@ -114,10 +114,10 @@
 		goto create;
 
 	/* preserve node with already correct numbers, to not change the inode number */
-	if (((stats.st_mode & S_IFMT) == S_IFBLK || (stats.st_mode & S_IFMT) == S_IFCHR) &&
+	if (((stats.st_mode & S_IFMT) == (mode & S_IFMT)) &&
 	    (stats.st_rdev == makedev(major, minor))) {
 		dbg("preserve file '%s', cause it has correct dev_t", file);
-		goto perms;
+		goto exit;
 	}
 
 	if (unlink(file) != 0)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]