Hi Christophe,

I've made a patch to multipath-tools 0.2.4 to correctly decipher SCSI 
EVPD page 0x83. The current code is totally ignorant of the fact that 
EVPD page 0x83 can return more than one identifier, some of which are 
either bogus (i.e. containing an empty string) or should be preferred to 
the other identifiers.

The attached patch
- correctly deciphers EVPD page 0x83
- Tries to select the 'best' candidate if several IDs are returned:
   - ID should not be empty (i.e. either only spaces or Nulls)
   - Order of preference:
	- NAA (hightest subtype is preferrred)
	- EUI-64
	- T-10
	- Vendor specific
- Map spaces to underscores if the serial number is ASCII; this is 	
   mainly to generate valid mapping names.

Would be great if this patch could be included, as without this the 
multipath tools do not work correctly with the IBM ESS.

Most of the decoding logic is in fact stolen from scsi_id (thanks 
Patrick), so we should probably add a copyright statement somewhere.

We should actually be using the scsi_id package directly as this would 
give us identical mappings for udev and multipath tools. But as this 
would mean a major restructuring of the program itself I took the cheap 
way out. Patrick, can you think of a clever way of integrating both?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux AG				S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de