Re: Cleaned up udev-selinux patch

[Daniel J Walsh <dwalsh@redhat.com>]

Greg KH wrote:

>On Thu, Aug 26, 2004 at 01:41:03PM -0400, Daniel J Walsh wrote:
>  
>
>>Greg KH wrote:
>>
>>    
>>
>>>On Thu, Aug 26, 2004 at 11:15:07AM -0400, Daniel J Walsh wrote:
>>>
>>>
>>>      
>>>
>>>>This will create the security contexts on the fly.
>>>>
>>>>Please comment on what would be needed to get this acceptable?
>>>>  
>>>>
>>>>        
>>>>
>>>Same things I said on the mailing list:
>>>	- fix coding style
>>>	- no ifdefs in .c files
>>>	- make the selinux stuff all be in its own file
>>>	- make the build flag look like the other build flags
>>>	- not make the makefile changes have silly line continuations
>>>	  when not needed :)
>>>	- post the patch on the mailing list (linux-hotplug-devel) for
>>>	  others to comment on after fixing the above.
>>>
>>>thanks,
>>>
>>>greg k-h
>>>
>>>
>>>      
>>>
>>Another pass at a cleaned up patch.  This time attempting to folow Greg 
>>guidelines.
>>    
>>
>
>Looks good.  Do you really want it all in a .h file?  I don't mind
>having the selinux functions being in a .c file and building that if
>USE_SELINUX is enabled.
>
>But it's your call, as you are the one going to have to live with the
>code :)
>
>thanks,
>
>greg k-h
>  
>
I copied the way it was being done with logging.h

I already have some updates from comments from other people.

Dan


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel