[PATCH] ensure that udev's Makefile respects DESTDIR when creating

[PATCH] ensure that udev's Makefile respects DESTDIR when creating

[Kevin P. Fleming]

Submitted By: David Jensen (djensen@inebraska.com)
Date: 2004-10-07
Initial Package Version: udev-033
Upstream Status: Pending
Origin: Joint development between David Jensen and Kevin Fleming
Description: Makes udev respect the DESTDIR parameter passed to the makefile


--- udev-035.orig/Makefile	2004-10-06 18:29:03.000000000 -0500
+++ udev-035/Makefile	2004-10-07 09:32:41.685906408 -0500
@@ -397,9 +397,9 @@
  	$(INSTALL_PROGRAM) -D $(INFO) $(DESTDIR)$(usrbindir)/$(INFO)
  	$(INSTALL_PROGRAM) -D $(TESTER) $(DESTDIR)$(usrbindir)/$(TESTER)
  	$(INSTALL_PROGRAM) -D $(WAIT) $(DESTDIR)$(sbindir)/$(WAIT)
-	- ln -f -s $(sbindir)/udev $(DESTDIR)$(sbindir)/$(STARTER)
-	- ln -f -s $(sbindir)/$(SENDER) $(DESTDIR)$(hotplugdir)/10-udev.hotplug
-	- ln -f -s $(sbindir)/$(WAIT) $(DESTDIR)$(hotplugdir)/05-wait_for_sysfs.hotplug
+	- ln -f -s $(DESTDIR)$(sbindir)/udev $(DESTDIR)$(sbindir)/$(STARTER)
+	- ln -f -s $(DESTDIR)$(sbindir)/$(SENDER) $(DESTDIR)$(hotplugdir)/10-udev.hotplug
+	- ln -f -s $(DESTDIR)$(sbindir)/$(WAIT) $(DESTDIR)$(hotplugdir)/05-wait_for_sysfs.hotplug
  ifndef DESTDIR
  	- killall udevd
  	- rm -f $(udevdir)/.udev.tdb


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: [PATCH] ensure that udev's Makefile respects DESTDIR when creating

[Harald Hoyer]

Kevin P. Fleming wrote:
> Submitted By: David Jensen (djensen@inebraska.com)
> Date: 2004-10-07
> Initial Package Version: udev-033
> Upstream Status: Pending
> Origin: Joint development between David Jensen and Kevin Fleming
> Description: Makes udev respect the DESTDIR parameter passed to the 
> makefile
> 
> 
> --- udev-035.orig/Makefile    2004-10-06 18:29:03.000000000 -0500
> +++ udev-035/Makefile    2004-10-07 09:32:41.685906408 -0500
> @@ -397,9 +397,9 @@
>      $(INSTALL_PROGRAM) -D $(INFO) $(DESTDIR)$(usrbindir)/$(INFO)
>      $(INSTALL_PROGRAM) -D $(TESTER) $(DESTDIR)$(usrbindir)/$(TESTER)
>      $(INSTALL_PROGRAM) -D $(WAIT) $(DESTDIR)$(sbindir)/$(WAIT)
> -    - ln -f -s $(sbindir)/udev $(DESTDIR)$(sbindir)/$(STARTER)
> -    - ln -f -s $(sbindir)/$(SENDER) 
> $(DESTDIR)$(hotplugdir)/10-udev.hotplug
> -    - ln -f -s $(sbindir)/$(WAIT) 
> $(DESTDIR)$(hotplugdir)/05-wait_for_sysfs.hotplug
> +    - ln -f -s $(DESTDIR)$(sbindir)/udev $(DESTDIR)$(sbindir)/$(STARTER)
> +    - ln -f -s $(DESTDIR)$(sbindir)/$(SENDER) 
> $(DESTDIR)$(hotplugdir)/10-udev.hotplug
> +    - ln -f -s $(DESTDIR)$(sbindir)/$(WAIT) 
> $(DESTDIR)$(hotplugdir)/05-wait_for_sysfs.hotplug
>  ifndef DESTDIR
>      - killall udevd
>      - rm -f $(udevdir)/.udev.tdb
> 


This would result to bad symlinks for e.g. rpm builds, cause the symlinks would point to the $RPM_BUILD_ROOT.
Use "configure prefix=", if you want to install to a different location.


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: [PATCH] ensure that udev's Makefile respects DESTDIR when creating

[Kevin P. Fleming]

Harald Hoyer wrote:

> This would result to bad symlinks for e.g. rpm builds, cause the 
> symlinks would point to the $RPM_BUILD_ROOT.
> Use "configure prefix=", if you want to install to a different location.

That was our original plan, but prefix= is applied to "udevdir" as well, 
which makes things complicated.

We'll come up with a new patch when we have a better solution. It would 
be ideal if the symlinks could be created as relative links, rather than 
absolute, but I don't think that's possible.


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel