From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Randy.Dunlap" Date: Wed, 20 Oct 2004 23:26:57 +0000 Subject: [PATCH] eth1394: dev file [Report about error: unknown bus] Message-Id: <4176F441.9040806@osdl.org> MIME-Version: 1 Content-Type: multipart/mixed; boundary="------------080905060902090602060505" List-Id: To: linux-hotplug@vger.kernel.org This is a multi-part message in MIME format. --------------080905060902090602060505 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Kay Sievers wrote: > On Wed, Oct 20, 2004 at 01:44:58PM -0400, Paul Blazejowski wrote: > >>On Wed, 2004-10-20 at 15:17 +0200, Kay Sievers wrote: >> >> >>>>'/class/net/eth1' properly (no device symlink) or the sysfs-support of >>>>your device's driver needs to be fixed >>> >>>What driver creates the eth1 device? It needs to crete the "device" symlink >>>and the maintainer should know. >> >>eth1 Link encap:UNSPEC HWaddr >>8A-1C-C7-FF-FF-00-20-ED-00-00-00-00-00-00-00-00 >> >>is created by the eth1394 driver. > > > [CC: to the 1394 devel-list] > > The eth1394.c driver needs to create the symlinks in its sysfs > representation to get support for modern userspace integration. > Most networkd drivers use: > > SET_NETDEV_DEV(dev, &pdev->dev); > > to do that. Paul, Can you test this patch, please? Thanks, -- ~Randy --------------080905060902090602060505 Content-Type: text/x-patch; name="eth1394_sysfs.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="eth1394_sysfs.patch" linux-269-bk4 description diffstat:= diff -Naurp ./drivers/ieee1394/eth1394.c~eth1394_sysfs ./drivers/ieee1394/eth1394.c --- ./drivers/ieee1394/eth1394.c~eth1394_sysfs 2004-10-20 16:01:51.765776760 -0700 +++ ./drivers/ieee1394/eth1394.c 2004-10-20 16:27:33.126454320 -0700 @@ -600,6 +600,7 @@ static void ether1394_add_host (struct h } SET_MODULE_OWNER(dev); + SET_NETDEV_DEV(dev, &host->device); priv = netdev_priv(dev); --------------080905060902090602060505-- ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel