From: Hannes Reinecke <hare@suse.de>
To: linux-hotplug@vger.kernel.org
Subject: Fix udev_volume_id for reiserfs v3.5
Date: Tue, 15 Mar 2005 13:18:34 +0000 [thread overview]
Message-ID: <4236E0AA.8000605@suse.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 535 bytes --]
Hi Kay,
the attached patch fixes udev_volume_id for old reiserfs volumes.
How are we supposed to handle old/invalid labels?
The one I'm reading here is
eb 4d 72 17 06 4e 72 17 09 4e 72 17 53 4e 72 17
which is clearly bogus. I'll check with our fs-gurus but I think
we should filter them out in udev_volume_id.
Can't we test for isascii(rs->label[0]) ?
Cheers,
Hannes
--
Dr. Hannes Reinecke hare@suse.de
SuSE Linux AG S390 & zSeries
Maxfeldstraße 5 +49 911 74053 688
90409 Nürnberg http://www.suse.de
[-- Attachment #2: udev-053-bk-fix-reiserfs-v35.patch --]
[-- Type: text/plain, Size: 500 bytes --]
===== extras/volume_id/volume_id/reiserfs.c 1.7 vs edited =====
--- 1.7/extras/volume_id/volume_id/reiserfs.c 2005-03-09 16:58:00 +01:00
+++ edited/extras/volume_id/volume_id/reiserfs.c 2005-03-15 13:31:53 +01:00
@@ -80,6 +80,10 @@
return -1;
rs = (struct reiserfs_super_block *) buf;;
+ if (memcmp(rs->magic, "ReIsErFs", 9) == 0) {
+ strcpy(id->type_version, "3.5");
+ goto found_v3;
+ }
if (memcmp(rs->magic, "ReIsEr2Fs", 9) == 0) {
strcpy(id->type_version, "3.6");
goto found_v3;
next reply other threads:[~2005-03-15 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 13:18 Hannes Reinecke [this message]
2005-03-15 14:55 ` Fix udev_volume_id for reiserfs v3.5 Kay Sievers
2005-03-15 15:17 ` Hannes Reinecke
2005-03-15 15:49 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4236E0AA.8000605@suse.de \
--to=hare@suse.de \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).