From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Date: Tue, 15 Mar 2005 13:18:34 +0000 Subject: Fix udev_volume_id for reiserfs v3.5 Message-Id: <4236E0AA.8000605@suse.de> MIME-Version: 1 Content-Type: multipart/mixed; boundary="------------010904040202020806050605" List-Id: To: linux-hotplug@vger.kernel.org This is a multi-part message in MIME format. --------------010904040202020806050605 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi Kay, the attached patch fixes udev_volume_id for old reiserfs volumes. How are we supposed to handle old/invalid labels? The one I'm reading here is eb 4d 72 17 06 4e 72 17 09 4e 72 17 53 4e 72 17 which is clearly bogus. I'll check with our fs-gurus but I think we should filter them out in udev_volume_id. Can't we test for isascii(rs->label[0]) ? Cheers, Hannes --=20 Dr. Hannes Reinecke hare@suse.de SuSE Linux AG S390 & zSeries Maxfeldstra=DFe 5 +49 911 74053 688 90409 N=FCrnberg http://www.suse.de --------------010904040202020806050605 Content-Type: text/plain; name="udev-053-bk-fix-reiserfs-v35.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="udev-053-bk-fix-reiserfs-v35.patch" ===== extras/volume_id/volume_id/reiserfs.c 1.7 vs edited ===== --- 1.7/extras/volume_id/volume_id/reiserfs.c 2005-03-09 16:58:00 +01:00 +++ edited/extras/volume_id/volume_id/reiserfs.c 2005-03-15 13:31:53 +01:00 @@ -80,6 +80,10 @@ return -1; rs = (struct reiserfs_super_block *) buf;; + if (memcmp(rs->magic, "ReIsErFs", 9) == 0) { + strcpy(id->type_version, "3.5"); + goto found_v3; + } if (memcmp(rs->magic, "ReIsEr2Fs", 9) == 0) { strcpy(id->type_version, "3.6"); goto found_v3; --------------010904040202020806050605-- ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel