From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Date: Tue, 15 Mar 2005 15:17:46 +0000 Subject: Re: Fix udev_volume_id for reiserfs v3.5 Message-Id: <4236FC9A.8010903@suse.de> MIME-Version: 1 Content-Type: multipart/mixed; boundary="------------080404070108070608050504" List-Id: References: <4236E0AA.8000605@suse.de> In-Reply-To: <4236E0AA.8000605@suse.de> To: linux-hotplug@vger.kernel.org This is a multi-part message in MIME format. --------------080404070108070608050504 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Kay Sievers wrote: > On Tue, 2005-03-15 at 14:18 +0100, Hannes Reinecke wrote: >>the attached patch fixes udev_volume_id for old reiserfs volumes. >=20 > The signature for that version can be at the offset of the later > versions? We already check for that signature at a different offset. >=20 Appearently so. >>How are we supposed to handle old/invalid labels? >>The one I'm reading here is >>eb 4d 72 17 06 4e 72 17 09 4e 72 17 53 4e 72 17 >>which is clearly bogus. I'll check with our fs-gurus but I think >>we should filter them out in udev_volume_id. >>Can't we test for isascii(rs->label[0]) ? >=20 > If that helps, sure. But what if the garbage starts at the second char? > And what's with the UTF8 char sequences? >=20 Well, I just asked our resident reiserfs guru (thx mason :-). Reiser v3.5 does not support labels nor uuids. Corrected patch attached. Cheers, Hannes --=20 Dr. Hannes Reinecke hare@suse.de SuSE Linux AG S390 & zSeries Maxfeldstra=C3=9Fe 5 +49 911 74053 688 90409 N=C3=BCrnberg http://www.suse.de --------------080404070108070608050504 Content-Type: text/plain; name="udev-053-bk-fix-reiserfs-v35.patch" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="udev-053-bk-fix-reiserfs-v35.patch" PT09PT0gZXh0cmFzL3ZvbHVtZV9pZC92b2x1bWVfaWQvcmVpc2VyZnMuYyAxLjcgdnMgZWRp dGVkID09PT09Ci0tLSAxLjcvZXh0cmFzL3ZvbHVtZV9pZC92b2x1bWVfaWQvcmVpc2VyZnMu YwkyMDA1LTAzLTA5IDE2OjU4OjAwICswMTowMAorKysgZWRpdGVkL2V4dHJhcy92b2x1bWVf aWQvdm9sdW1lX2lkL3JlaXNlcmZzLmMJMjAwNS0wMy0xNSAxNjoxNDoyMyArMDE6MDAKQEAg LTgwLDYgKzgwLDEwIEBACiAJCXJldHVybiAtMTsKIAogCXJzID0gKHN0cnVjdCByZWlzZXJm c19zdXBlcl9ibG9jayAqKSBidWY7OworCWlmIChtZW1jbXAocnMtPm1hZ2ljLCAiUmVJc0Vy RnMiLCA4KSA9PSAwKSB7CisJCXN0cmNweShpZC0+dHlwZV92ZXJzaW9uLCAiMy41Iik7CisJ CWdvdG8gZm91bmQ7CisJfQogCWlmIChtZW1jbXAocnMtPm1hZ2ljLCAiUmVJc0VyMkZzIiwg OSkgPT0gMCkgewogCQlzdHJjcHkoaWQtPnR5cGVfdmVyc2lvbiwgIjMuNiIpOwogCQlnb3Rv IGZvdW5kX3YzOwpAQCAtMTA0LDcgKzEwOCw3IEBACiAKIAlpZiAobWVtY21wKHJzLT5tYWdp YywgIlJlSXNFckZzIiwgOCkgPT0gMCkgewogCQlzdHJjcHkoaWQtPnR5cGVfdmVyc2lvbiwg IjMuNSIpOwotCQlnb3RvIGZvdW5kX3YzOworCQlnb3RvIGZvdW5kOwogCX0KIAogCXJldHVy biAtMTsK --------------080404070108070608050504-- ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel