From: Vassilis Virvilis <vasvir@iit.demokritos.gr>
To: linux-hotplug@vger.kernel.org
Subject: patch udev: static linking and DESTDIR
Date: Fri, 20 May 2005 11:34:47 +0000 [thread overview]
Message-ID: <428DCB57.6020201@iit.demokritos.gr> (raw)
[-- Attachment #1: Type: text/plain, Size: 923 bytes --]
This patch does two things
1)
Note: klcc builds statically by default so I don't see the reason to
explicitly state it. However if somebody changes the default behavior of
klcc (like me) it will lost considerable time trying to find out why
hotplug (and udev) doesn't build statically (like me).
2)
I am building hotplug (and udev) for an initramfs image. I have
specified DESTDIR to be ~/src/embed/root-initramfs and the defines
as they are now are pointing to DESTDIR which is wrong since that
directory will be the root upon boot and udev cannot find the
~/src/embed/root-initramfs/sbin/udev staff.
Note the klibc works around this by introducing INSTALLROOT and
INSTALLDIR Makefile variables. Maybe something like this is a good idea?
Also note that the INSTALL_DIR variable in udev makefile is useless as
it is not referenced anywhere. Would you accept a patch to clean it up
as it is distracting...
.bill
[-- Attachment #2: patch-udev --]
[-- Type: text/plain, Size: 936 bytes --]
diff -ur orig/udev-057/Makefile udev-057/Makefile
--- orig/udev-057/Makefile 2005-04-15 00:39:34.000000000 +0300
+++ udev-057/Makefile 2005-05-19 18:43:43.000000000 +0300
@@ -178,7 +178,7 @@
KLCC = $(KLIBC_INSTALL)/bin/klcc
CC = $(KLCC)
LD = $(KLCC)
- LDFLAGS += -static
+ #LDFLAGS += -static
else
CFLAGS += -Wshadow -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations
endif
@@ -250,8 +250,8 @@
@echo \#define UDEV_CONFIG_DIR \"$(configdir)\" >> $@
@echo \#define UDEV_CONFIG_FILE \"$(configdir)/udev.conf\" >> $@
@echo \#define UDEV_RULES_FILE \"$(configdir)/rules.d\" >> $@
- @echo \#define UDEV_BIN \"$(DESTDIR)$(sbindir)/udev\" >> $@
- @echo \#define UDEVD_BIN \"$(DESTDIR)$(sbindir)/udevd\" >> $@
+ @echo \#define UDEV_BIN \"$(sbindir)/udev\" >> $@
+ @echo \#define UDEVD_BIN \"$(sbindir)/udevd\" >> $@
# Rules on how to create the generated config files
$(LOCAL_CFG_DIR)/udev.conf:
next reply other threads:[~2005-05-20 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-20 11:34 Vassilis Virvilis [this message]
2005-05-22 14:07 ` patch udev: static linking and DESTDIR Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428DCB57.6020201@iit.demokritos.gr \
--to=vasvir@iit.demokritos.gr \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).