From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Paulson-Ellis Date: Fri, 23 Dec 2005 00:12:18 +0000 Subject: Re: /dev/disk/by-id incomplete and unhelpful for SATA drives Message-Id: <43AB40E2.1050009@edesix.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Bill Nottingham wrote: > Chris Paulson-Ellis (chris@edesix.com) said: > >>KERNEL="sd*[!0-9]", ENV{ID_SERIAL}="*_Linux_ATA-SCSI_simulator", >>IMPORT="/sbin/scsi_id -g -x -s %p -d %N -p 0x80" >> >>I'm not sure which fix is better. Perhaps the scsi_id.config fix, as the >>udev rule could contradict an entry in scsi_id.config, confusing the >>user. Then again, the rule is only run if neccessary and I prefer to >>have only one place to look (the udev rules) to see what is happening. > > > Why not just fix the kernel when it's filling in the page 83 > data to pull the serial from page 80 instead of putting *that* there? > > Bill Indeed. Here's the patch. Now I have 3 ways to fix this. Any more anyone? --- drivers/scsi/libata-scsi.c.orig 2005-12-22 23:23:55.000000000 +0000 +++ drivers/scsi/libata-scsi.c 2005-12-22 23:56:14.000000000 +0000 @@ -1532,16 +1532,13 @@ return 0; } -static const char *inq_83_str = "Linux ATA-SCSI simulator"; - /** * ata_scsiop_inq_83 - Simulate INQUIRY EVPD page 83, device identity * @args: device IDENTIFY data / SCSI command of interest. * @rbuf: Response buffer, to which simulated SCSI cmd output is sent. * @buflen: Response buffer length. * - * Returns device identification. Currently hardcoded to - * return "Linux ATA-SCSI simulator". + * Returns ATA device serial number (as for page 80). * * LOCKING: * spin_lock_irqsave(host_set lock) @@ -1551,13 +1548,14 @@ unsigned int buflen) { rbuf[1] = 0x83; /* this page code */ - rbuf[3] = 4 + strlen(inq_83_str); /* page len */ + rbuf[3] = 4 + ATA_SERNO_LEN; /* page len */ /* our one and only identification descriptor (vendor-specific) */ - if (buflen > (strlen(inq_83_str) + 4 + 4 - 1)) { + if (buflen > (ATA_SERNO_LEN + 4 + 4 - 1)) { rbuf[4 + 0] = 2; /* code set: ASCII */ - rbuf[4 + 3] = strlen(inq_83_str); - memcpy(rbuf + 4 + 4, inq_83_str, strlen(inq_83_str)); + rbuf[4 + 3] = ATA_SERNO_LEN; + ata_dev_id_string(args->id, (unsigned char *) rbuf + 4 + 4, + ATA_ID_SERNO_OFS, ATA_SERNO_LEN); } return 0; ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_idv37&alloc_id865&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel