linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Moshe Yudkowsky <msha5_17@bl.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: Why not picking up ENV variables?
Date: Tue, 04 Apr 2006 11:20:27 +0000	[thread overview]
Message-ID: <4432567B.8060901@bl.com> (raw)
In-Reply-To: <442FD482.5000707@bl.com>

This patch didn't seem to help.

> Could you try if this patch helps?
> 
> diff --git a/udev_device.c b/udev_device.c
> index 5db2709..cd84a0a 100644
> - --- a/udev_device.c
> +++ b/udev_device.c
> @@ -101,6 +101,7 @@ int udev_device_event(struct udev_rules
>         if (major(udev->devt) != 0 && strcmp(udev->action, "remove") = 0) {
>                 struct name_entry *name_loop;
> 
> +               udev_db_get_device(udev, udev->dev->devpath);
>                 udev_rules_get_run(rules, udev);
>                 if (udev->ignore_device) {
>                         info("device event will be ignored");
> 
> - -andrey

(1) The relevant lines in udev_device.c now read:

	if (major(udev->devt) != 0 && strcmp(udev->action, "remove") = 0) {
		struct name_entry *name_loop;

		udev_db_get_device(udev, udev->dev->devpath);
		udev_rules_get_run(rules, udev);
		if (udev->ignore_device) {
			info("device event will be ignored");
			return 0;
		}

and then I simply ran:

make
make install

in my normal environment. I didn't make or install, e.g., ata-id.


(2) On unplug, the output of udevmonitor --env  reads:

> UDEV  [1144149290.702789] remove@/block/sdb
> UDEV_LOG=3
> ACTION=remove
> DEVPATH=/block/sdb
> SUBSYSTEM=block
> SEQNUM374
> MINOR\x16
> MAJOR=8
> PHYSDEVPATH=/devices/pci0000:00/0000:00:10.3/usb4/4-4/4-4:1.0/host21/target21:0:0/21:0:0:0
> PHYSDEVBUS=scsi
> PHYSDEVDRIVER=sd
> UDEVD_EVENT=1
> DEVLINKS=/dev/sdb /dev/discs/disc2/disc /dev/disk/by-id/usb-iriver_MassStorage_Disc /dev/disk/by-path/pci-0000:00:10.3-usb-0:4:1.0-scsi-0:0:0:0 /dev/iriverDEVNAME=/dev/scsi/host21/bus0/target0/lun0/disc
> ID_VENDOR=iriver
> ID_MODEL=MassStorage_Disc
> ID_REVISION\001
> ID_SERIAL=iriver_MassStorage_Disc
> ID_TYPE=disk
> ID_BUS=usb
> ID_PATH=pci-0000:00:10.3-usb-0:4:1.0-scsi-0:0:0:0
> REMOVE_CMD=/etc/hotplug/usb/iriver remove


(3) the rules are (the "add" rule works, the "remove" does not):

SUBSYSTEM="block" IMPORT{program}="path_id $devpath"

SUBSYSTEM="block", ACTION="add", ENV{ID_VENDOR}="iriver", 
ENV{ID_SERIAL}="iriver_MassStorage_Disc", SYMLINK+="iriver", 
RUN+="/etc/hotplug/usb/iriver", ENV{REMOVE_CMD}="/etc/hotplug/usb/iriver 
remove"

SUBSYSTEM="block", ACTION="remove",  ENV{ID_VENDOR}="iriver", 
ENV{ID_SERIAL}="iriver_MassStorage_Disc", RUN+="/etc/hotplug/usb/iriver"


Please let me know what further tests to run.


-- 
  Moshe Yudkowsky
  work: http://www.Disaggregate.com
  book: http://www.PebbleAndAvalanche.com


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x110944&bid$1720&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

  parent reply	other threads:[~2006-04-04 11:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-02 13:41 Why not picking up ENV variables? Moshe Yudkowsky
2006-04-02 14:58 ` Moshe Yudkowsky
2006-04-02 16:47 ` Andrey Borzenkov
2006-04-02 19:48 ` Moshe Yudkowsky
2006-04-04 11:20 ` Moshe Yudkowsky [this message]
2006-04-04 16:31 ` Andrey Borzenkov
2006-04-04 17:40 ` Moshe Yudkowsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4432567B.8060901@bl.com \
    --to=msha5_17@bl.com \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).