[PATCH] typo in firmware.sh

[PATCH] typo in firmware.sh

[Martin Langer]

This looks like a missing slash typo in firmware.sh. 

Signed-off-by: Martin Langer <martin-langer@gmx.de>


--- extras/firmware/firmware.sh.ORIGINAL	2006-07-10 15:19:47.000000000 +0200
+++ extras/firmware/firmware.sh	2006-07-10 15:20:21.000000000 +0200
@@ -9,7 +9,7 @@
     fi
 }
 
-if [ ! -e /sys$DEVPATH/loading ]; then
+if [ ! -e /sys/$DEVPATH/loading ]; then
     err "udev firmware loader misses sysfs directory"
     exit 1
 fi



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x120709&bid&3057&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: [PATCH] typo in firmware.sh

[Kay Sievers]

On Mon, 2006-07-10 at 15:28 +0200, Martin Langer wrote:
> This looks like a missing slash typo in firmware.sh. 
> 
> Signed-off-by: Martin Langer <martin-langer@gmx.de>
> 
> 
> --- extras/firmware/firmware.sh.ORIGINAL	2006-07-10 15:19:47.000000000 +0200
> +++ extras/firmware/firmware.sh	2006-07-10 15:20:21.000000000 +0200
> @@ -9,7 +9,7 @@
>      fi
>  }
>  
> -if [ ! -e /sys$DEVPATH/loading ]; then
> +if [ ! -e /sys/$DEVPATH/loading ]; then
>      err "udev firmware loader misses sysfs directory"
>      exit 1
>  fi

DEVPATH always starts with a slash.

Kay



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x120709&bid&3057&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: [PATCH] typo in firmware.sh

[Alexander E. Patrakov]

Martin Langer wrote:
> This looks like a missing slash typo in firmware.sh.

> -if [ ! -e /sys$DEVPATH/loading ]; then
> +if [ ! -e /sys/$DEVPATH/loading ]; then

$DEVPATH is something that already begins with a slash.

-- 
Alexander E. Patrakov


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x120709&bid&3057&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: [PATCH] typo in firmware.sh

[Michael Buesch]

On Monday 10 July 2006 15:28, Martin Langer wrote:
> This looks like a missing slash typo in firmware.sh. 
> 
> Signed-off-by: Martin Langer <martin-langer@gmx.de>
> 
> 
> --- extras/firmware/firmware.sh.ORIGINAL	2006-07-10 15:19:47.000000000 +0200
> +++ extras/firmware/firmware.sh	2006-07-10 15:20:21.000000000 +0200
> @@ -9,7 +9,7 @@
>      fi
>  }
>  
> -if [ ! -e /sys$DEVPATH/loading ]; then
> +if [ ! -e /sys/$DEVPATH/loading ]; then

Nope, $DEVPATH includes a leading slash.
But for consistency reasons I would say you
could make a patch to remove the slash at the other uses
of $DEVPATH in the file. ;)

-- 
Greetings Michael.


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x120709&bid&3057&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel