Re: Some changes in write-cd-rules script

[Piter PUNK <piterpk@terra.com.br>]

md wrote:
> Your first problem is that you do not understand the locking rules used
> by the script.
> 
>> +if ! egrep "^ENV{ID_CDROM}=\"\?\*\", ENV{ID_PATH}=\"$ID_PATH\"" /etc/udev/rules.d/* &>/dev/null ; then 
>> +	# Prevent concurrent processes from modifying the file at the same time.
>> +	lock_rules_file
> 
> This creates a race.

You are correct. The test needs to be after the lock_rules_file.
In our script (cdrom-symlinks.sh) it is after the locking.

> Also, checking all files in the directory is broken because some may not
> be rules files.

I don't know that. I was thinking udev looks in all files under
/etc/udev/rules.d. Now i test renaming some files to DONTRUN, README,
etc.. and it really doesn't read this files. Changing the grep to
*.rules will solve it.

> I think that there are other problems, but I have not examined carefully
> the script.

Good, i will be happy with your feedback.

							Piter PUNK
-- 
     |        E-Mail: piterpk@terra.com.br        (personal)
    .|.               roberto.batista@ntux.com.br (professional)
    /V\
   // \\      UIN:116043354  Homepage:http://piterpunk.info02.com.br
  /(   )\
   ^`~'^         ----> Slackware Linux - The Best One! <----
  #105432

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x120709&bid&3057&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel