From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Beshers Date: Tue, 06 Mar 2007 15:15:42 +0000 Subject: Re: PATCH udev-106 /proc/stat buffer to small Message-Id: <45ED859E.9080802@sgi.com> List-Id: References: <45EC7EE4.5000903@sgi.com> In-Reply-To: <45EC7EE4.5000903@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-hotplug@vger.kernel.org First, I will post an improved patch as I completely forgot udev was threaded (duh..). Kay Sievers wrote: > On 3/5/07, George Beshers wrote: >> >> I am assuming that this is the correct place to post udev patches for >> consideration, feel free to inform me otherwise :-). > >> This came up on a system with 1024cores (well 768cpus and 256 >> hyper-threads) where the buffer size for reading /proc/stat was >> not large enough causing udev to fail during the boot process. > > "fail"? What fails? How? It should still find hundreds of your CPU's,=20 > right? Yes and no as it turns out because udev also looks at procs_running=20 which is at the end of the list. If the buffer isn't big enough it returns an=20 error, does a lame boot, and puts FAILED rather than OK in the syslog. > >> The read_proc_stat(void) eliminates this problem. > > Just curious, what size is the content of /proc/stat on this box? Aprox 48000 is my memory -- well above the 32768 that the buffer size was. Really want this to scale to 4k or so without doing anything terrible to the 1p 128meg systems that still exist. > > Thanks, > Kay ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=DEVD= EV _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel