From: Bryan Kadzban <bryan@kadzban.is-a-geek.net>
To: linux-hotplug@vger.kernel.org
Subject: Couple more sample rules typos
Date: Sat, 13 Oct 2007 20:31:24 +0000 [thread overview]
Message-ID: <47112B1C.1030900@kadzban.is-a-geek.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 1650 bytes --]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160
There are two more missing commas in the sample rules files: in the
auer[0-9]* rule, and in the SUBSYSTEMS=="bsg" rule. The attached patch
(generated against the current git tree) adds them.
These are the only two instances of missing commas in the current files,
according to the following test:
grep --color '="[^"]*"[^,]' etc/udev/rules.d/*.rules
which tests for an equals sign, then any value between a single set of
double quotes, then any character other than a comma. It then prints
out the matching string in red by default (depends on $GREP_COLOR).
(That test will trigger a false positive if the value between double
quotes uses any escaped double quotes itself. No current rules do that
though, so for the moment, it's OK.)
That test also triggered on a trailing space in the DVB rule. The space
doesn't seem to affect anything, but since removing it won't affect
anything either, and it's a false positive on the test above, I think it
should be removed. I've done that in this patch as well.
(Would it be easy to add an automated test for this to the package, or
to the git repo? Commas have been removed or forgotten a few times now;
it seems like a good idea to have some kind of automatic test for that
to me, if it's not too hard to set up. I'd suspect the grep above would
be a decent starting place for the test.)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHESsaS5vET1Wea5wRA56ZAKCaR4LjF3Yal/KPHLShRsBAewO4xgCgo42p
VEOFvo4F3V9I/fx/R0GXQZY=
=NejA
-----END PGP SIGNATURE-----
[-- Attachment #2: udev-current-git-fix-typos.patch --]
[-- Type: text/plain, Size: 1220 bytes --]
diff -ur a/etc/udev/rules.d/50-udev-default.rules b/etc/udev/rules.d/50-udev-default.rules
--- a/etc/udev/rules.d/50-udev-default.rules 2007-10-13 16:09:50.000000000 -0400
+++ b/etc/udev/rules.d/50-udev-default.rules 2007-10-13 16:10:41.000000000 -0400
@@ -39,7 +39,7 @@
KERNEL=="fb0", SYMLINK+="fb"
# DVB video
-SUBSYSTEM=="dvb", PROGRAM="/bin/sh -c 'K=%k; K=$${K#dvb}; printf dvb/adapter%%i/%%s $${K%%%%.*} $${K#*.}'", NAME="%c"
+SUBSYSTEM=="dvb", PROGRAM="/bin/sh -c 'K=%k; K=$${K#dvb}; printf dvb/adapter%%i/%%s $${K%%%%.*} $${K#*.}'", NAME="%c"
# Firewire
KERNEL=="dv1394*", SYMLINK+="dv1394/%n"
@@ -77,7 +77,7 @@
KERNEL=="pktcdvd[0-9]*", NAME="pktcdvd/%k"
KERNEL=="pktcdvd", NAME="pktcdvd/control"
KERNEL=="qft0", SYMLINK+="ftape"
-SUBSYSTEM=="bsg" NAME="bsg/%k"
+SUBSYSTEM=="bsg", NAME="bsg/%k"
# network
KERNEL=="tun", NAME="net/%k", MODE="0666", OPTIONS+="ignore_remove"
@@ -91,7 +91,7 @@
KERNEL=="fuse", MODE="0666"
KERNEL=="rtc|rtc0", MODE="0644"
KERNEL=="rtc0", SYMLINK+="rtc"
-KERNEL=="auer[0-9]*" NAME="usb/%k"
+KERNEL=="auer[0-9]*", NAME="usb/%k"
KERNEL=="hw_random", NAME="hwrng", SYMLINK+="%k"
KERNEL=="mmtimer", MODE="0644"
KERNEL=="rflash[0-9]*", MODE="0400"
[-- Attachment #3: Type: text/plain, Size: 314 bytes --]
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
[-- Attachment #4: Type: text/plain, Size: 226 bytes --]
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next reply other threads:[~2007-10-13 20:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-13 20:31 Bryan Kadzban [this message]
2007-10-14 19:16 ` Couple more sample rules typos Kay Sievers
2007-10-15 13:10 ` Matthias Schwarzott
2007-10-15 16:48 ` Bryan Kadzban
2007-10-15 19:43 ` VMiklos
2007-10-16 18:12 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47112B1C.1030900@kadzban.is-a-geek.net \
--to=bryan@kadzban.is-a-geek.net \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).