From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harald Hoyer Date: Wed, 11 Jun 2008 19:35:33 +0000 Subject: Re: scsi_id - EBUSY and serialization Message-Id: <48502905.7000207@redhat.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="------------ms050308050106030409060100" List-Id: References: <484FA10E.9010303@redhat.com> In-Reply-To: <484FA10E.9010303@redhat.com> To: linux-hotplug@vger.kernel.org This is a cryptographically signed message in MIME format. --------------ms050308050106030409060100 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Kay Sievers wrote: > On Wed, Jun 11, 2008 at 11:55 AM, Harald Hoyer wrote: >> We have a customer, who misses some symlinks for some of his scsi devices. >> Because of limited access and debugging facilities, I could only guess a >> fix. >> >> The first patch retries opening the scsi device, if it is EBUSY. >> The second patch serializes access with flock. >> >> With these patches it seems to work. I don't know if the flock patch is >> really necessary. Any help and comments appreciated. > >> - fd = open(devname, O_RDONLY | O_NONBLOCK); >> + while (((fd = open(devname, O_RDONLY | O_NONBLOCK)) != 0) && (cnt > > > What is open() != 0 doing? I guess you want < 0? errr... yes :) > >> + strncpy(flock_path, "/sys/", MAX_PATH_LEN-1); >> + strncat(flock_path, devpath, MAX_PATH_LEN-1); > > Current scsi_id has no idea about sysfs anymore. I guess, we should > try if the retry patch is enough. > > Kay if not, we could flock s.th. like "/dev/.udev/tmp_" + major + minor --------------ms050308050106030409060100 Content-Type: application/x-pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIKYjCC BS0wggMVoAMCAQICAwOoWjANBgkqhkiG9w0BAQUFADB5MRAwDgYDVQQKEwdSb290IENBMR4w HAYDVQQLExVodHRwOi8vd3d3LmNhY2VydC5vcmcxIjAgBgNVBAMTGUNBIENlcnQgU2lnbmlu ZyBBdXRob3JpdHkxITAfBgkqhkiG9w0BCQEWEnN1cHBvcnRAY2FjZXJ0Lm9yZzAeFw0wNzA2 MDYwNjQ5MDNaFw0wOTA2MDUwNjQ5MDNaMDkxFTATBgNVBAMTDEhhcmFsZCBIb3llcjEgMB4G CSqGSIb3DQEJARYRaGFyYWxkQHJlZGhhdC5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAw ggEKAoIBAQDcYRNZNcpUzmHaTtZXCPoLNJW7g0iD9Oo8BgGQDmLQPEIw05SINqk5f+YvIvoo a85lze7+bfhDg3MJmcTu5C8OKnej+GfZV8qVnLLg0F1d2pSc1oKTarasUN+BSNTn8mc+BlKM jEF5I4faGGATEgM/1pkscRofiQoWDvMAHsD/UVErVTKzLT03vczQutUYfHJuGJohXdJubQdJ C2AyXqLJBkvns+0pNGB7qMHTVPWm9+v1I18iz0sXe5hOsTMIJFFCkia41ZVpGkwU/9ITVLtY E+UmW897Tpi4uUE5YsPVoA3u5YIFlQFkwW1Zp9bAlmFGNlUUe2UEvpTAWWVte+qBAgMBAAGj gf0wgfowDAYDVR0TAQH/BAIwADBWBglghkgBhvhCAQ0ESRZHVG8gZ2V0IHlvdXIgb3duIGNl cnRpZmljYXRlIGZvciBGUkVFIGhlYWQgb3ZlciB0byBodHRwOi8vd3d3LkNBY2VydC5vcmcw QAYDVR0lBDkwNwYIKwYBBQUHAwQGCCsGAQUFBwMCBgorBgEEAYI3CgMEBgorBgEEAYI3CgMD BglghkgBhvhCBAEwMgYIKwYBBQUHAQEEJjAkMCIGCCsGAQUFBzABhhZodHRwOi8vb2NzcC5j YWNlcnQub3JnMBwGA1UdEQQVMBOBEWhhcmFsZEByZWRoYXQuY29tMA0GCSqGSIb3DQEBBQUA A4ICAQAyKBirdOIjYdzfQAhpme6t2gg/cAzxITk4Vq+DpoxSJ8JD8f6mlQoMblC9zCFAWk7X K14/NteDFhb/ufDfAlWsJSQ9MSl//r8IGPIclaO+G+cGYkP2xiENDcG8169UYG9ocIUCHNNl mW0HuvFPHVQjnmwNRH3rLW7MPJiVdCj5ALsNDqiCsfc/Jqak+6jlVf6aMVcWtTCqlHouiwJ6 830tviRC0QiZD3eSUn1XpDULypMtkCwAnHPFpc+JEBJEKC1XO7kR4XtQPB87pEOrRfszv4uI PzRnhAy0lBrS7zuyi3w1UqpQ92fTkiRDOLcEwpUwhmrZGYFsrJ5J4dfxvmw8mgUssb2InIDT 8wYV+GGo+nM289sFBEy/y5LGluQZqPF0gOjzr10YFDUdvqeixfAFLHfXZtEINboRDMY7EPkP slY1AbnIGMaqdBn0LZRl3/z7GV2TjKuMkm8fiOtFblqb0SeXpRX2XA30xqX9xSbA/6ec/aUP SsdCxkFkRXB8X7fsVJUnLODt85em7ZDXCZhgJI9rFm2pRVOdJB3/OFEbdP5v6ovG6f5kQncw 6U0vgs5r/ZdziWfeAFVVSp5Qw/1ii6zWiS2/fK0acD0ovIQYYrh2NQWnjgXwJ0+1RnuSMUCs uo0yCMJt2mI5UyeOrIv0+ceYmEOEjV8w3cexGuylKTCCBS0wggMVoAMCAQICAwOoWjANBgkq hkiG9w0BAQUFADB5MRAwDgYDVQQKEwdSb290IENBMR4wHAYDVQQLExVodHRwOi8vd3d3LmNh Y2VydC5vcmcxIjAgBgNVBAMTGUNBIENlcnQgU2lnbmluZyBBdXRob3JpdHkxITAfBgkqhkiG 9w0BCQEWEnN1cHBvcnRAY2FjZXJ0Lm9yZzAeFw0wNzA2MDYwNjQ5MDNaFw0wOTA2MDUwNjQ5 MDNaMDkxFTATBgNVBAMTDEhhcmFsZCBIb3llcjEgMB4GCSqGSIb3DQEJARYRaGFyYWxkQHJl ZGhhdC5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDcYRNZNcpUzmHaTtZX CPoLNJW7g0iD9Oo8BgGQDmLQPEIw05SINqk5f+YvIvooa85lze7+bfhDg3MJmcTu5C8OKnej +GfZV8qVnLLg0F1d2pSc1oKTarasUN+BSNTn8mc+BlKMjEF5I4faGGATEgM/1pkscRofiQoW DvMAHsD/UVErVTKzLT03vczQutUYfHJuGJohXdJubQdJC2AyXqLJBkvns+0pNGB7qMHTVPWm 9+v1I18iz0sXe5hOsTMIJFFCkia41ZVpGkwU/9ITVLtYE+UmW897Tpi4uUE5YsPVoA3u5YIF lQFkwW1Zp9bAlmFGNlUUe2UEvpTAWWVte+qBAgMBAAGjgf0wgfowDAYDVR0TAQH/BAIwADBW BglghkgBhvhCAQ0ESRZHVG8gZ2V0IHlvdXIgb3duIGNlcnRpZmljYXRlIGZvciBGUkVFIGhl YWQgb3ZlciB0byBodHRwOi8vd3d3LkNBY2VydC5vcmcwQAYDVR0lBDkwNwYIKwYBBQUHAwQG CCsGAQUFBwMCBgorBgEEAYI3CgMEBgorBgEEAYI3CgMDBglghkgBhvhCBAEwMgYIKwYBBQUH AQEEJjAkMCIGCCsGAQUFBzABhhZodHRwOi8vb2NzcC5jYWNlcnQub3JnMBwGA1UdEQQVMBOB EWhhcmFsZEByZWRoYXQuY29tMA0GCSqGSIb3DQEBBQUAA4ICAQAyKBirdOIjYdzfQAhpme6t 2gg/cAzxITk4Vq+DpoxSJ8JD8f6mlQoMblC9zCFAWk7XK14/NteDFhb/ufDfAlWsJSQ9MSl/ /r8IGPIclaO+G+cGYkP2xiENDcG8169UYG9ocIUCHNNlmW0HuvFPHVQjnmwNRH3rLW7MPJiV dCj5ALsNDqiCsfc/Jqak+6jlVf6aMVcWtTCqlHouiwJ6830tviRC0QiZD3eSUn1XpDULypMt kCwAnHPFpc+JEBJEKC1XO7kR4XtQPB87pEOrRfszv4uIPzRnhAy0lBrS7zuyi3w1UqpQ92fT kiRDOLcEwpUwhmrZGYFsrJ5J4dfxvmw8mgUssb2InIDT8wYV+GGo+nM289sFBEy/y5LGluQZ qPF0gOjzr10YFDUdvqeixfAFLHfXZtEINboRDMY7EPkPslY1AbnIGMaqdBn0LZRl3/z7GV2T jKuMkm8fiOtFblqb0SeXpRX2XA30xqX9xSbA/6ec/aUPSsdCxkFkRXB8X7fsVJUnLODt85em 7ZDXCZhgJI9rFm2pRVOdJB3/OFEbdP5v6ovG6f5kQncw6U0vgs5r/ZdziWfeAFVVSp5Qw/1i i6zWiS2/fK0acD0ovIQYYrh2NQWnjgXwJ0+1RnuSMUCsuo0yCMJt2mI5UyeOrIv0+ceYmEOE jV8w3cexGuylKTGCA5QwggOQAgEBMIGAMHkxEDAOBgNVBAoTB1Jvb3QgQ0ExHjAcBgNVBAsT FWh0dHA6Ly93d3cuY2FjZXJ0Lm9yZzEiMCAGA1UEAxMZQ0EgQ2VydCBTaWduaW5nIEF1dGhv cml0eTEhMB8GCSqGSIb3DQEJARYSc3VwcG9ydEBjYWNlcnQub3JnAgMDqFowCQYFKw4DAhoF AKCCAegwGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMDgwNjEx MTkzNTMzWjAjBgkqhkiG9w0BCQQxFgQU1gA627oqLrX9bwPzmH/ZfcySLxAwXwYJKoZIhvcN AQkPMVIwUDALBglghkgBZQMEAQIwCgYIKoZIhvcNAwcwDgYIKoZIhvcNAwICAgCAMA0GCCqG SIb3DQMCAgFAMAcGBSsOAwIHMA0GCCqGSIb3DQMCAgEoMIGRBgkrBgEEAYI3EAQxgYMwgYAw eTEQMA4GA1UEChMHUm9vdCBDQTEeMBwGA1UECxMVaHR0cDovL3d3dy5jYWNlcnQub3JnMSIw IAYDVQQDExlDQSBDZXJ0IFNpZ25pbmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcNAQkBFhJzdXBw b3J0QGNhY2VydC5vcmcCAwOoWjCBkwYLKoZIhvcNAQkQAgsxgYOggYAweTEQMA4GA1UEChMH Um9vdCBDQTEeMBwGA1UECxMVaHR0cDovL3d3dy5jYWNlcnQub3JnMSIwIAYDVQQDExlDQSBD ZXJ0IFNpZ25pbmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcNAQkBFhJzdXBwb3J0QGNhY2VydC5v cmcCAwOoWjANBgkqhkiG9w0BAQEFAASCAQDW7DDzlNjnjxcEvVL//r7ESIQ00E5bqMc64V7W SS0TXFJTx5VNPa+5oEgCQ8iowjdAeszyunfgKf/SXQ/+i8xMceo7ftLF5zuSIv4bDto+cnyi Al3R/2Ua0ae4tnvRrqXlqB7MIyoGL8rqZD/7wy/ync2Z8WrPRCFeRAXvm88RM0PkX5Xets0o HXTecFgVJKocqJUGyNDWhi9khJazIIqDgE+36TkY0yc8uEBwFBWAPYyqSFLm95Olqb2/yUoY CjNgydcm0MLge51xddtHyrP0cvfV+0ilNVuQrLxjwCgz9361eXyykOYLhrgrfAuUVIEpEqcf 2bSdW5hK+6VUNKvSAAAAAAAA --------------ms050308050106030409060100--