[PATCH] The commented line in udev-test.pl to use valgrind needs

[PATCH] The commented line in udev-test.pl to use valgrind needs

[Alan Jenkins]

Also run with --quiet to show errors only.

Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>

diff --git a/test/udev-test.pl b/test/udev-test.pl
index ad551dd..6c51399 100755
--- a/test/udev-test.pl
+++ b/test/udev-test.pl
@@ -29,7 +29,7 @@ my $udev_rules	= "udev-test.rules";
 
 # uncomment following line to run udev with valgrind.
 # Should make this a runtime option to the script someday...
-#my $udev_bin  = "valgrind --tool=memcheck --leak-check=yes   ../udev";
+#$udev_bin  = "valgrind --tool=memcheck --leak-check=yes --quiet $udev_bin";
 
 my @tests = (
 	{

Re: [PATCH] The commented line in udev-test.pl to use valgrind needs fixing

[Kay Sievers]

On Sun, Aug 31, 2008 at 19:25, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
> Also run with --quiet to show errors only.
>
> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
>
> diff --git a/test/udev-test.pl b/test/udev-test.pl
> index ad551dd..6c51399 100755
> --- a/test/udev-test.pl
> +++ b/test/udev-test.pl
> @@ -29,7 +29,7 @@ my $udev_rules        = "udev-test.rules";
>
>  # uncomment following line to run udev with valgrind.
>  # Should make this a runtime option to the script someday...
> -#my $udev_bin  = "valgrind --tool=memcheck --leak-check=yes   ../udev";
> +#$udev_bin  = "valgrind --tool=memcheck --leak-check=yes --quiet $udev_bin";

I've added a --valgrind option instead, so there is no longer the need
to change the source file.

Thanks,
Kay

Re: [PATCH] The commented line in udev-test.pl to use valgrind needs

[Alan Jenkins]

Kay Sievers wrote:
> On Sun, Aug 31, 2008 at 19:25, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
>   
>> Also run with --quiet to show errors only.
>>
>> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
>>
>> diff --git a/test/udev-test.pl b/test/udev-test.pl
>> index ad551dd..6c51399 100755
>> --- a/test/udev-test.pl
>> +++ b/test/udev-test.pl
>> @@ -29,7 +29,7 @@ my $udev_rules        = "udev-test.rules";
>>
>>  # uncomment following line to run udev with valgrind.
>>  # Should make this a runtime option to the script someday...
>> -#my $udev_bin  = "valgrind --tool=memcheck --leak-check=yes   ../udev";
>> +#$udev_bin  = "valgrind --tool=memcheck --leak-check=yes --quiet $udev_bin";
>>     
>
> I've added a --valgrind option instead, so there is no longer the need
> to change the source file.
>
> Thanks,
> Kay
>   
Ah, you forgot to remove this line though:

# uncomment following line to run udev with valgrind.

Alan

Re: [PATCH] The commented line in udev-test.pl to use valgrind needs fixing

[Kay Sievers]

On Wed, Sep 3, 2008 at 14:50, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
> Kay Sievers wrote:
>> On Sun, Aug 31, 2008 at 19:25, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
>>
>>> Also run with --quiet to show errors only.
>>>
>>> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
>>>
>>> diff --git a/test/udev-test.pl b/test/udev-test.pl
>>> index ad551dd..6c51399 100755
>>> --- a/test/udev-test.pl
>>> +++ b/test/udev-test.pl
>>> @@ -29,7 +29,7 @@ my $udev_rules        = "udev-test.rules";
>>>
>>>  # uncomment following line to run udev with valgrind.
>>>  # Should make this a runtime option to the script someday...
>>> -#my $udev_bin  = "valgrind --tool=memcheck --leak-check=yes   ../udev";
>>> +#$udev_bin  = "valgrind --tool=memcheck --leak-check=yes --quiet $udev_bin";
>>>
>>
>> I've added a --valgrind option instead, so there is no longer the need
>> to change the source file.
>>
>> Thanks,
>> Kay
>>
> Ah, you forgot to remove this line though:

Removed.

Thanks,
Kay