linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] The commented line in udev-test.pl to use valgrind needs
Date: Wed, 03 Sep 2008 12:50:38 +0000	[thread overview]
Message-ID: <48BE881E.6050404@tuffmail.co.uk> (raw)
In-Reply-To: <48BAD418.1030708@tuffmail.co.uk>

Kay Sievers wrote:
> On Sun, Aug 31, 2008 at 19:25, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
>   
>> Also run with --quiet to show errors only.
>>
>> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
>>
>> diff --git a/test/udev-test.pl b/test/udev-test.pl
>> index ad551dd..6c51399 100755
>> --- a/test/udev-test.pl
>> +++ b/test/udev-test.pl
>> @@ -29,7 +29,7 @@ my $udev_rules        = "udev-test.rules";
>>
>>  # uncomment following line to run udev with valgrind.
>>  # Should make this a runtime option to the script someday...
>> -#my $udev_bin  = "valgrind --tool=memcheck --leak-check=yes   ../udev";
>> +#$udev_bin  = "valgrind --tool=memcheck --leak-check=yes --quiet $udev_bin";
>>     
>
> I've added a --valgrind option instead, so there is no longer the need
> to change the source file.
>
> Thanks,
> Kay
>   
Ah, you forgot to remove this line though:

# uncomment following line to run udev with valgrind.

Alan

  parent reply	other threads:[~2008-09-03 12:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-31 17:25 [PATCH] The commented line in udev-test.pl to use valgrind needs Alan Jenkins
2008-09-01 14:29 ` [PATCH] The commented line in udev-test.pl to use valgrind needs fixing Kay Sievers
2008-09-03 12:50 ` Alan Jenkins [this message]
2008-09-03 20:02 ` Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48BE881E.6050404@tuffmail.co.uk \
    --to=alan-jenkins@tuffmail.co.uk \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).