From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Jenkins Date: Wed, 03 Sep 2008 12:50:38 +0000 Subject: Re: [PATCH] The commented line in udev-test.pl to use valgrind needs Message-Id: <48BE881E.6050404@tuffmail.co.uk> List-Id: References: <48BAD418.1030708@tuffmail.co.uk> In-Reply-To: <48BAD418.1030708@tuffmail.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Kay Sievers wrote: > On Sun, Aug 31, 2008 at 19:25, Alan Jenkins wrote: > >> Also run with --quiet to show errors only. >> >> Signed-off-by: Alan Jenkins >> >> diff --git a/test/udev-test.pl b/test/udev-test.pl >> index ad551dd..6c51399 100755 >> --- a/test/udev-test.pl >> +++ b/test/udev-test.pl >> @@ -29,7 +29,7 @@ my $udev_rules = "udev-test.rules"; >> >> # uncomment following line to run udev with valgrind. >> # Should make this a runtime option to the script someday... >> -#my $udev_bin = "valgrind --tool=memcheck --leak-check=yes ../udev"; >> +#$udev_bin = "valgrind --tool=memcheck --leak-check=yes --quiet $udev_bin"; >> > > I've added a --valgrind option instead, so there is no longer the need > to change the source file. > > Thanks, > Kay > Ah, you forgot to remove this line though: # uncomment following line to run udev with valgrind. Alan