From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Jenkins Date: Wed, 10 Sep 2008 10:21:05 +0000 Subject: Re: [PATCH 2/3] sysfs: sysfs_attr_get_value() writes to a buffer Message-Id: <48C79F91.7010007@tuffmail.co.uk> List-Id: References: <48BFEEF4.8040000@tuffmail.co.uk> In-Reply-To: <48BFEEF4.8040000@tuffmail.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Alan Jenkins wrote: > This avoids lifetime issues with the returned string, for subsequent changes > to caching in sysfs. All callers are changed accordingly. Many callers > copied the result to a buffer already, so this actually simplifies some code. > Sorry, my re-implementation of sysfs_attr_get_value() was defective. It didn't return cached values correctly. I suggest you drop these two patches. I'll fix the bug and update them to apply on top of the recent libudev/logging changes. Thanks Alan