linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] udevd: fix WAIT_FOR_SYSFS
Date: Thu, 23 Oct 2008 19:56:36 +0000	[thread overview]
Message-ID: <4900D6F4.9060207@tuffmail.co.uk> (raw)
In-Reply-To: <4900C46A.7070501@tuffmail.co.uk>

Kay Sievers wrote:
> On Thu, Oct 23, 2008 at 21:03, Kay Sievers <kay.sievers@vrfy.org> wrote:
>   
>> On Thu, Oct 23, 2008 at 20:37, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
>>     
>>> The wait should be ordered after matching KERNEL, ENV, etc.
>>> but before ATTR.
>>>
>>> Without this, WAIT_FOR_SYSFS rules will be applied unconditionally
>>> to all events.
>>>       
>> Ah, nice! Thanks for finding that out. I do not have any of theses
>> rules left, as there are currently no know issues with recent kernels.
>> :) Applied.
>>     
>
> Oh, now that I expect it works for you without the long delay. :) How
> does is compare? Is it still slower?
>
> Thanks,
> Kay
>   

No, that fixed it.  The network interface rename problem seems to have
gone as well (!).

I just tested it on my desktop.  oprofile says it now _reduces_ cpu
cycles in udevd by 10%.  Not big enough to show up in time(1), but not
bad!  And it should help more on the EeePC, which has a less lavish cpu
cache.

Alan

  parent reply	other threads:[~2008-10-23 19:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-23 18:37 [PATCH] udevd: fix WAIT_FOR_SYSFS Alan Jenkins
2008-10-23 19:03 ` Kay Sievers
2008-10-23 19:12 ` Kay Sievers
2008-10-23 19:56 ` Alan Jenkins [this message]
2008-10-25 13:33 ` Kay Sievers
2008-10-25 16:19 ` Alan Jenkins
2008-10-25 17:19 ` Alan Jenkins
2008-10-25 17:46 ` Kay Sievers
2008-10-25 17:48 ` Kay Sievers
2008-10-25 17:57 ` Alan Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4900D6F4.9060207@tuffmail.co.uk \
    --to=alan-jenkins@tuffmail.co.uk \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).