From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Jenkins Date: Thu, 23 Oct 2008 19:56:36 +0000 Subject: Re: [PATCH] udevd: fix WAIT_FOR_SYSFS Message-Id: <4900D6F4.9060207@tuffmail.co.uk> List-Id: References: <4900C46A.7070501@tuffmail.co.uk> In-Reply-To: <4900C46A.7070501@tuffmail.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Kay Sievers wrote: > On Thu, Oct 23, 2008 at 21:03, Kay Sievers wrote: > >> On Thu, Oct 23, 2008 at 20:37, Alan Jenkins wrote: >> >>> The wait should be ordered after matching KERNEL, ENV, etc. >>> but before ATTR. >>> >>> Without this, WAIT_FOR_SYSFS rules will be applied unconditionally >>> to all events. >>> >> Ah, nice! Thanks for finding that out. I do not have any of theses >> rules left, as there are currently no know issues with recent kernels. >> :) Applied. >> > > Oh, now that I expect it works for you without the long delay. :) How > does is compare? Is it still slower? > > Thanks, > Kay > No, that fixed it. The network interface rename problem seems to have gone as well (!). I just tested it on my desktop. oprofile says it now _reduces_ cpu cycles in udevd by 10%. Not big enough to show up in time(1), but not bad! And it should help more on the EeePC, which has a less lavish cpu cache. Alan