From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Thomas Date: Tue, 09 Dec 2008 03:07:15 +0000 Subject: Re: [PATCH] Standard rules for AoE devices. Message-Id: <493DE0E3.3070606@coraid.com> List-Id: References: <493DB75B.5090309@coraid.com> In-Reply-To: <493DB75B.5090309@coraid.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Kay Sievers wrote: > On Tue, Dec 9, 2008 at 01:49, Marco d'Itri wrote: >> On Dec 09, Ryan Thomas wrote: >> >>> In the interest of standardizing udev rules, please consider the >>> following patch that adds udev rules for the ATA over Ethernet character >>> and block devices. The aoe module has been a long-time member of the >>> kernel and needs inclusion in the standard udev rules. >> Debian so far has used these rules which are more generic and much >> simpler. Are they incorrect in some way? >> >> # AOE character devices >> SUBSYSTEM="aoe", NAME="etherd/%k" >> >> SUBSYSTEM="aoe", MODE="0220", GROUP="disk" >> SUBSYSTEM="aoe", KERNEL="err", MODE="0440", GROUP="disk" > > That looks fine. > > I wonder why we have this comment: > +# aoe block devices > +SUBSYSTEM="aoe", KERNEL="etherd*", NAME="%k", GROUP="disk" > > They can not be block devices if they have SUBSYSTEM="aoe". Do the > etherd* devices belong into the subdir or not? > > We have: > SUBSYSTEM="aoe", NAME="etherd/%k", GROUP="disk" > in the current default rules. > > I guess doing: > # ATA over Ethernet > SUBSYSTEM="aoe", NAME="etherd/%k", GROUP="disk", MODE="0220" > SUBSYSTEM="aoe", KERNEL="err", MODE="0440" > would be all we need. > > Kay > My previous patch should be backed out as you are right that it's not needed. A patch to the default rules to correct the mode on the etherd/err character device is all that is needed. Thanks for the help straightening this (and me) out. Ryan --- rules/rules.d/50-udev-default.rules | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/rules/rules.d/50-udev-default.rules b/rules/rules.d/50-udev-default.rules index 2743dcb..0f27982 100644 --- a/rules/rules.d/50-udev-default.rules +++ b/rules/rules.d/50-udev-default.rules @@ -87,7 +87,7 @@ KERNEL="pktcdvd[0-9]*", NAME="pktcdvd/%k" KERNEL="pktcdvd", NAME="pktcdvd/control" KERNEL="qft0", SYMLINK+="ftape" SUBSYSTEM="bsg", NAME="bsg/%k" -SUBSYSTEM="aoe", NAME="etherd/%k", GROUP="disk" +SUBSYSTEM="aoe", NAME="etherd/%k", GROUP="disk", MODE="0220" SUBSYSTEM="aoe", KERNEL="err", MODE="0440" # network -- 1.5.6.5