selinux version to link against libsepol, too

selinux version to link against libsepol, too

[Harald Hoyer]

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: udev-135-sepol.patch --]
[-- Type: text/plain, Size: 767 bytes --]

commit 9aa4548cb8720f772ca5e3648d689fbd931dffe1
Author: Harald Hoyer <harald@redhat.com>
Date:   Tue Dec 16 10:48:21 2008 +0100

    LDFLAGS="-all-static" and configure --withselinux needs to link against libsepol, too

diff --git a/configure.ac b/configure.ac
index 4439166..cd4ccc5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -55,6 +55,13 @@ if test "x$with_selinux" = xyes; then
 	AC_DEFINE(USE_SELINUX, [1] ,[compile with SELinux support])
 	SELINUX_LIBS="-lselinux"
 fi
+if test "x$with_selinux" = xyes; then
+	LIBS_save=$LIBS
+	AC_CHECK_LIB(sepol, sepol_genbools,
+		[SELINUX_LIBS="$SELINUX_LIBS -lsepol"],
+		[])
+	LIBS=$LIBS_save
+fi
 AC_SUBST([SELINUX_LIBS])
 AM_CONDITIONAL(USE_SELINUX, [test "x$with_selinux" = xyes], [compile with SELinux support])
 

Re: selinux version to link against libsepol, too

[Kay Sievers]

On Tue, Dec 16, 2008 at 10:54, Harald Hoyer <harald@redhat.com> wrote:
>
> commit 9aa4548cb8720f772ca5e3648d689fbd931dffe1
> Author: Harald Hoyer <harald@redhat.com>
> Date:   Tue Dec 16 10:48:21 2008 +0100
>
>    LDFLAGS="-all-static" and configure --withselinux needs to link against libsepol, too

Why do we need to check for sepol to be available, we can just add it
unconditionally, right?

What are you doing with -all-static? You still put static crap in your
initrd? :)

Thanks,
Kay

Re: selinux version to link against libsepol, too

[Harald Hoyer]

Kay Sievers wrote:
> On Tue, Dec 16, 2008 at 10:54, Harald Hoyer <harald@redhat.com> wrote:
>> commit 9aa4548cb8720f772ca5e3648d689fbd931dffe1
>> Author: Harald Hoyer <harald@redhat.com>
>> Date:   Tue Dec 16 10:48:21 2008 +0100
>>
>>    LDFLAGS="-all-static" and configure --withselinux needs to link against libsepol, too
> 
> Why do we need to check for sepol to be available, we can just add it
> unconditionally, right?

hmm, maybe :)

> 
> What are you doing with -all-static? You still put static crap in your
> initrd? :)

We never used static crap in our initrd (from udev), but I provide udev-static 
as an rpm for those who might need it. :-)

> 
> Thanks,
> Kay

Re: selinux version to link against libsepol, too

[Kay Sievers]

On Tue, Dec 16, 2008 at 15:13, Harald Hoyer <harald@redhat.com> wrote:
> Kay Sievers wrote:
>>
>> On Tue, Dec 16, 2008 at 10:54, Harald Hoyer <harald@redhat.com> wrote:
>>>
>>> commit 9aa4548cb8720f772ca5e3648d689fbd931dffe1
>>> Author: Harald Hoyer <harald@redhat.com>
>>> Date:   Tue Dec 16 10:48:21 2008 +0100
>>>
>>>   LDFLAGS="-all-static" and configure --withselinux needs to link against
>>> libsepol, too
>>
>> Why do we need to check for sepol to be available, we can just add it
>> unconditionally, right?
>
> hmm, maybe :)

That's how it was before we switched to autotools. The -as-needed
should take care of stripping it again.

>> What are you doing with -all-static? You still put static crap in your
>> initrd? :)
>
> We never used static crap in our initrd (from udev), but I provide
> udev-static as an rpm for those who might need it. :-)

Yeah, it's christmas time, and we want to make the hopelessly clueless
happy. I understand. :)

Kay

Re: selinux version to link against libsepol, too

[Kay Sievers]

On Tue, Dec 16, 2008 at 16:04, Kay Sievers <kay.sievers@vrfy.org> wrote:
> On Tue, Dec 16, 2008 at 15:13, Harald Hoyer <harald@redhat.com> wrote:
>> Kay Sievers wrote:
>>>
>>> On Tue, Dec 16, 2008 at 10:54, Harald Hoyer <harald@redhat.com> wrote:
>>>>
>>>> commit 9aa4548cb8720f772ca5e3648d689fbd931dffe1
>>>> Author: Harald Hoyer <harald@redhat.com>
>>>> Date:   Tue Dec 16 10:48:21 2008 +0100
>>>>
>>>>   LDFLAGS="-all-static" and configure --withselinux needs to link against
>>>> libsepol, too
>>>
>>> Why do we need to check for sepol to be available, we can just add it
>>> unconditionally, right?
>>
>> hmm, maybe :)
>
> That's how it was before we switched to autotools. The -as-needed
> should take care of stripping it again.

Added it.

Btw, why does libselinux not ship with a pkgconfig file? Do you have
that on your system?

That would make all that work without these ugly workarounds.

Thanks,
Kay

Re: selinux version to link against libsepol, too

[Harald Hoyer]

Kay Sievers wrote:
> On Tue, Dec 16, 2008 at 16:04, Kay Sievers <kay.sievers@vrfy.org> wrote:
>> On Tue, Dec 16, 2008 at 15:13, Harald Hoyer <harald@redhat.com> wrote:
>>> Kay Sievers wrote:
>>>> On Tue, Dec 16, 2008 at 10:54, Harald Hoyer <harald@redhat.com> wrote:
>>>>> commit 9aa4548cb8720f772ca5e3648d689fbd931dffe1
>>>>> Author: Harald Hoyer <harald@redhat.com>
>>>>> Date:   Tue Dec 16 10:48:21 2008 +0100
>>>>>
>>>>>   LDFLAGS="-all-static" and configure --withselinux needs to link against
>>>>> libsepol, too
>>>> Why do we need to check for sepol to be available, we can just add it
>>>> unconditionally, right?
>>> hmm, maybe :)
>> That's how it was before we switched to autotools. The -as-needed
>> should take care of stripping it again.
> 
> Added it.
> 
> Btw, why does libselinux not ship with a pkgconfig file? Do you have
> that on your system?

Don't know. No, no pkgconfig file.

> 
> That would make all that work without these ugly workarounds.

Well, well.. ;-)

> 
> Thanks,
> Kay
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html