linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Harald Hoyer <harald@redhat.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: MD removal and condition code bug
Date: Thu, 05 Feb 2009 13:18:33 +0000	[thread overview]
Message-ID: <498AE729.30602@redhat.com> (raw)
In-Reply-To: <498A9893.5090505@redhat.com>

Harald Hoyer wrote:
> Kay Sievers wrote:
>> On Thu, Feb 5, 2009 at 08:43, Harald Hoyer <harald@redhat.com> wrote:
>>> Radek Vykydal <rvykydal@redhat.com> encountered a problem with md 
>>> devices.
>>> If the raid is about to be removed a "change" and "remove" event is 
>>> sent.
>>> The "change" event has to be skipped if ATTR{md/array_state} is 
>>> empty, but
>>> somehow the condition does not match, which might point to a bug in the
>>> condition code.
>>> The following patch is needed:
>>>
>>> < ATTR{md/array_state}="|clear|inactive", GOTO="md_end"
>>> ---
>>>> ATTR{md/array_state}="clear|inactive", GOTO="md_end"
>>>> ATTR(md/array_state}!="?*", GOTO="md_end"
>>
>> A non-existent attribute makes the rule always fail. Are you sure, the
>> second rule will fix the issue? It should also never match, when the
>> attribute is no longer available. I guess, we need to add a TEST!= key
>> here.
>>
>> Thanks,
>> Kay
> 
> The attribute exists, but is empty.

ok.. wrong :) actually it is missing..

  parent reply	other threads:[~2009-02-05 13:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05  7:43 MD removal and condition code bug Harald Hoyer
2009-02-05 11:35 ` Kay Sievers
2009-02-05 11:39 ` Harald Hoyer
2009-02-05 13:18 ` Harald Hoyer [this message]
2009-02-05 13:22 ` Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498AE729.30602@redhat.com \
    --to=harald@redhat.com \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).