From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: linux-hotplug@vger.kernel.org
Subject: Re: udev_queue_get_seqnum_is_finished
Date: Thu, 23 Apr 2009 12:43:55 +0000 [thread overview]
Message-ID: <49F0628B.8020808@tuffmail.co.uk> (raw)
In-Reply-To: <49F0374E.2070000@tuffmail.co.uk>
Kay Sievers wrote:
> On Thu, Apr 23, 2009 at 13:20, Kay Sievers <kay.sievers@vrfy.org> wrote:
>
>> On Thu, Apr 23, 2009 at 11:39, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
>>
>
>
>>> Shouldn't the test be (seqnum > udev_queue->last_seen_udev_seqnum) ?
>>> I.e. "greater than" instead of "less than".
>>>
>> Sounds like.
>>
>
> Care to check, if that makes sense now:
> http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;hŒ3ae78546a535cc9288a190680fb1eb88c6ea7e
>
Yes, that makes sense now. Except for the comment, which seems to
accurately describes the old, confused code :-)
/* if we have not seen this seqnum, check if it is/was already queued */
to match the new code, I think it would be
/* if we have seen this seqnum, check if it is still queued */
Ta
Alan
next prev parent reply other threads:[~2009-04-23 12:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 9:39 udev_queue_get_seqnum_is_finished Alan Jenkins
2009-04-23 11:20 ` udev_queue_get_seqnum_is_finished Kay Sievers
2009-04-23 11:34 ` udev_queue_get_seqnum_is_finished Kay Sievers
2009-04-23 12:43 ` Alan Jenkins [this message]
2009-04-23 12:54 ` udev_queue_get_seqnum_is_finished Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F0628B.8020808@tuffmail.co.uk \
--to=alan-jenkins@tuffmail.co.uk \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).